[igt-dev] [PATCH] [NEW]kms_chamelium: Add new EDID stress resolution test

Dixit, Ashutosh ashutosh.dixit at intel.com
Tue Nov 1 23:04:29 UTC 2022


On Tue, 01 Nov 2022 09:30:42 -0700, Mark Yacoub wrote:
> +static void edid_stress_resolution(data_t *data, struct chamelium_port *port,
> +				   monitor_edid edids_list[],
> +				   size_t edids_list_len)
> +{
> +	int i;
> +	struct chamelium *chamelium = data->chamelium;
> +	struct udev_monitor *mon = igt_watch_uevents();
> +
> +	for (i = 0; i < edids_list_len; ++i) {
> +		struct chamelium_edid *chamelium_edid;
> +		drmModeModeInfo mode;
> +		struct igt_fb fb = { 0 };
> +		igt_output_t *output;
> +		enum pipe pipe;
> +		bool is_video_stable;
> +		int screen_res_w, screen_res_h;
> +
> +		monitor_edid *monitor_edid = &edids_list[i];

No warnings please.

../tests/chamelium/kms_chamelium.c: In function ‘edid_stress_resolution’:
../tests/chamelium/kms_chamelium.c:2570:31: warning: declaration of ‘monitor_edid’ shadows a global declaration [-Wshadow]
 2570 |                 monitor_edid *monitor_edid = &edids_list[i];
      |                               ^~~~~~~~~~~~
In file included from ../lib/monitor_edids/dp_edids.h:15,
                 from ../tests/chamelium/kms_chamelium.c:33:
../lib/monitor_edids/monitor_edids_helper.h:25:3: note: shadowed declaration is here
   25 | } monitor_edid;
      |   ^~~~~~~~~~~~


More information about the igt-dev mailing list