[igt-dev] [PATCH i-g-t 3/6] tests/v3d: Remove unused or redundant includes

Maíra Canal mcanal at igalia.com
Tue Nov 8 23:57:21 UTC 2022


The V3D test files contain some includes that aren't required for
compilation: some includes are simply not used and others are included
through other headers. Simplify the code by removing unused includes.

Signed-off-by: Maíra Canal <mcanal at igalia.com>
---
 lib/igt_v3d.c                 |  3 ---
 tests/v3d/v3d_get_bo_offset.c | 12 ------------
 tests/v3d/v3d_get_param.c     | 12 ------------
 tests/v3d/v3d_mmap.c          | 12 ------------
 4 files changed, 39 deletions(-)

diff --git a/lib/igt_v3d.c b/lib/igt_v3d.c
index 619c072c..bd645320 100644
--- a/lib/igt_v3d.c
+++ b/lib/igt_v3d.c
@@ -36,9 +36,6 @@
 #include "igt_core.h"
 #include "igt_v3d.h"
 #include "ioctl_wrappers.h"
-#include "intel_reg.h"
-#include "intel_chipset.h"
-#include "v3d_drm.h"
 
 /**
  * SECTION:igt_v3d
diff --git a/tests/v3d/v3d_get_bo_offset.c b/tests/v3d/v3d_get_bo_offset.c
index 0923dc85..976a28b8 100644
--- a/tests/v3d/v3d_get_bo_offset.c
+++ b/tests/v3d/v3d_get_bo_offset.c
@@ -23,18 +23,6 @@
 
 #include "igt.h"
 #include "igt_v3d.h"
-#include <unistd.h>
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
-#include <fcntl.h>
-#include <inttypes.h>
-#include <errno.h>
-#include <sys/stat.h>
-#include <sys/ioctl.h>
-#include <poll.h>
-#include "v3d_drm.h"
-#include "igt_v3d.h"
 
 igt_main
 {
diff --git a/tests/v3d/v3d_get_param.c b/tests/v3d/v3d_get_param.c
index 76563406..816a3c7d 100644
--- a/tests/v3d/v3d_get_param.c
+++ b/tests/v3d/v3d_get_param.c
@@ -23,18 +23,6 @@
 
 #include "igt.h"
 #include "igt_v3d.h"
-#include <unistd.h>
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
-#include <fcntl.h>
-#include <inttypes.h>
-#include <errno.h>
-#include <sys/stat.h>
-#include <sys/ioctl.h>
-#include <poll.h>
-#include "v3d_drm.h"
-#include "igt_v3d.h"
 
 igt_main
 {
diff --git a/tests/v3d/v3d_mmap.c b/tests/v3d/v3d_mmap.c
index a6fe7e5a..ad441607 100644
--- a/tests/v3d/v3d_mmap.c
+++ b/tests/v3d/v3d_mmap.c
@@ -23,18 +23,6 @@
 
 #include "igt.h"
 #include "igt_v3d.h"
-#include <unistd.h>
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
-#include <fcntl.h>
-#include <inttypes.h>
-#include <errno.h>
-#include <sys/stat.h>
-#include <sys/ioctl.h>
-#include <poll.h>
-#include "v3d_drm.h"
-#include "igt_v3d.h"
 
 igt_main
 {
-- 
2.38.1



More information about the igt-dev mailing list