[igt-dev] [PATCH i-g-t] lib/i915_blt: Narrow setting same pitch and aux-ccs to Tile64 only

Kamil Konieczny kamil.konieczny at linux.intel.com
Tue Nov 15 09:12:51 UTC 2022


On 2022-11-14 at 18:07:21 +0100, Zbigniew Kempczyński wrote:
> In commit 229bb0accbb7 ("lib/i915_blt: equalize pitch and aux-ccs for
> full resolve") i've incidentally introduce partial regression for x-major
> and Tile4.
> 
> Limit equalizing pitch and aux-ccs for full-resolve to Tile64 only.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  lib/i915/i915_blt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/i915/i915_blt.c b/lib/i915/i915_blt.c
> index a886c1d72d..3776c56c60 100644
> --- a/lib/i915/i915_blt.c
> +++ b/lib/i915/i915_blt.c
> @@ -317,7 +317,7 @@ static void fill_data(struct gen12_block_copy_data *data,
>  	data->dw00.special_mode = __special_mode(blt);
>  	data->dw00.length = extended_command ? 20 : 10;
>  
> -	if (__special_mode(blt) == SM_FULL_RESOLVE) {
> +	if (__special_mode(blt) == SM_FULL_RESOLVE && blt->src.tiling == T_TILE64) {
>  		data->dw01.dst_pitch = blt->src.pitch - 1;
>  		data->dw01.dst_aux_mode = __aux_mode(&blt->src);
>  	} else {
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list