[igt-dev] [PATCH i-g-t 0/4] Remove libdrm remnants in i915 code

Kamil Konieczny kamil.konieczny at linux.intel.com
Thu Nov 24 10:39:00 UTC 2022


Hi Zbigniew,

On 2022-11-22 at 15:00:03 +0100, Zbigniew Kempczyński wrote:
> I want finally remove all libdrm stuff, to get this I had to:
> 
> 1. remove prime_udl tests - it is not used in CI due to lack of 
>    DisplayLink hardware,
> 2. remove prime_nv_* tests - similar, there's no compatible hw
>    I can rewrite the test and it is not exercised by CI so lets
>    get rid of it. If someone is complaining we can back to it
>    in the future or is welcome to rewrite it.

imho it will be good to send these two removals in separate
patchset so it will be more visibile to anyone interested.

Regards,
Kamil

> 3. rewrite intel_upload_blit_* benchmarks - I tried to mimic 
>    behavior as much as possible but there'e some minor differences
>    in execution time. I think it is related to libdrm internals
>    (how it caches handles/mappings). I'm not sure but it shouldn't
>    much affect what benchmark is exercising.
> 4. remove all intel_batchbuffer_* code
> 
> Cc: Petri Latvala <petri.latvala at intel.com>
> 
> Zbigniew Kempczyński (4):
>   tests/prime_udl: Remove prime_udl test
>   tests/prime_nv_*: Remove prime_nv_* tests
>   benchmarks/intel_upload_blit_*: Remove libdrm in upload blits
>   lib/intel_batchbuffer: Get rid of libdrm batchbuffer
> 
>  benchmarks/intel_upload_blit_large.c     | 131 ++--
>  benchmarks/intel_upload_blit_large_gtt.c | 130 ++--
>  benchmarks/intel_upload_blit_large_map.c | 132 ++--
>  benchmarks/intel_upload_blit_small.c     | 139 ++--
>  lib/intel_batchbuffer.c                  | 574 +-------------
>  lib/intel_batchbuffer.h                  | 248 -------
>  tests/meson.build                        |   4 -
>  tests/prime_nv_api.c                     | 410 ----------
>  tests/prime_nv_pcopy.c                   | 905 -----------------------
>  tests/prime_nv_test.c                    | 399 ----------
>  tests/prime_udl.c                        | 160 ----
>  11 files changed, 313 insertions(+), 2919 deletions(-)
>  delete mode 100644 tests/prime_nv_api.c
>  delete mode 100644 tests/prime_nv_pcopy.c
>  delete mode 100644 tests/prime_nv_test.c
>  delete mode 100644 tests/prime_udl.c
> 
> -- 
> 2.34.1
> 


More information about the igt-dev mailing list