[igt-dev] [PATCH i-g-t 0/4] Remove libdrm remnants in i915 code

[Zbigniew Kempczyński]

On Thu, Nov 24, 2022 at 12:46:19PM +0200, Petri Latvala wrote:
> On Tue, Nov 22, 2022 at 03:00:03PM +0100, Zbigniew Kempczyński wrote:
> > I want finally remove all libdrm stuff, to get this I had to:
> > 
> > 1. remove prime_udl tests - it is not used in CI due to lack of 
> >    DisplayLink hardware,
> > 2. remove prime_nv_* tests - similar, there's no compatible hw
> >    I can rewrite the test and it is not exercised by CI so lets
> >    get rid of it. If someone is complaining we can back to it
> >    in the future or is welcome to rewrite it.
> > 3. rewrite intel_upload_blit_* benchmarks - I tried to mimic 
> >    behavior as much as possible but there'e some minor differences
> >    in execution time. I think it is related to libdrm internals
> >    (how it caches handles/mappings). I'm not sure but it shouldn't
> >    much affect what benchmark is exercising.
> > 4. remove all intel_batchbuffer_* code
> > 
> > Cc: Petri Latvala <petri.latvala at intel.com>
> > 
> > Zbigniew Kempczyński (4):
> >   tests/prime_udl: Remove prime_udl test
> >   tests/prime_nv_*: Remove prime_nv_* tests
> >   benchmarks/intel_upload_blit_*: Remove libdrm in upload blits
> >   lib/intel_batchbuffer: Get rid of libdrm batchbuffer
> 
> Old unused tests with old structuring of writing tests, e.g. not really
> using the multidevice selection mechanisms and whatnot.
> 
> If someone needs them back, please rewrite them.

Ok, will do. But at the moment I'm going to remove above.

> 
> For the series:
> Acked-by: Petri Latvala <petri.latvala at intel.com>
> 
> Although I have to say I'm also not sure whether the benchmark changes
> are 100% equivalent or even correct...

Me either, but according to what libdrm is doing (caching mapping/objects
are not really freed) I'm not sure about intention of author. Especially
that some operations are just bypassed (cached, like for mappings).

If someone will complain about I above (benchmarks) I will fix it later. 

--
Zbigniew

> 
> 
> -- 
> Petri Latvala