[igt-dev] [RFC PATCH v3 5/8] lib/tests/igt_fork: change comments into prints

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Nov 25 12:01:45 UTC 2022


Print some info about what is tested to simplify debugging.

Signed-off-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
---
 lib/tests/igt_fork.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/lib/tests/igt_fork.c b/lib/tests/igt_fork.c
index b3a97fd1..54a8b8b9 100644
--- a/lib/tests/igt_fork.c
+++ b/lib/tests/igt_fork.c
@@ -170,26 +170,27 @@ int main(int argc, char **argv)
 	for (fork_type_dyn = 0;	fork_type_dyn <= 1; ++fork_type_dyn) {
 		printf("Checking fork%s ...\n", fork_type_dyn ? "_dyn" : "");
 
-		/* check that igt_assert is forwarded */
+		printf("\ncheck that igt_assert is forwarded\n");
 		ret = do_fork(igt_fork_vs_assert);
 		internal_assert_wexited(ret, IGT_EXIT_FAILURE);
 
-		/* check that igt_skip within a fork blows up */
+		printf("\ncheck that igt_skip within a fork blows up\n");
 		ret = do_fork(igt_fork_vs_skip);
 		internal_assert_wexited(ret, SIGABRT + 128);
 
-		/* check that failure to clean up fails */
+		printf("\ncheck that failure to clean up fails\n");
 		ret = do_fork(igt_fork_leak);
 		internal_assert_wsignaled(ret, SIGABRT);
 
-		/* check that igt_waitchildren_timeout cleans up*/
+		printf("\ncheck that igt_waitchildren_timeout cleans up\n");
 		ret = do_fork(igt_fork_timeout_leak);
 		internal_assert_wexited(ret, SIGKILL + 128);
 
-		/* check that any other process leaks are caught*/
+		printf("\ncheck that any other process leaks are caught\n");
 		ret = do_fork(plain_fork_leak);
 		internal_assert_wsignaled(ret, SIGABRT);
 
+		printf("\ncheck subtest leak %d\n", fork_type_dyn);
 		ret = do_fork(subtest_leak);
 		internal_assert_wexited(ret, IGT_EXIT_FAILURE); /* not asserted! */
 	}
-- 
2.34.1



More information about the igt-dev mailing list