[igt-dev] [PATCH i-g-t 1/5] tests/vc4: Move VC4 tests to their own folder

Melissa Wen mwen at igalia.com
Fri Nov 25 14:50:55 UTC 2022


On 11/15, Maíra Canal wrote:
> VC4 contains a substantial number of tests. In order to avoid polluting
> the main tests folder, move the VC4 tests to a separate folder.
> 
> Signed-off-by: Maíra Canal <mcanal at igalia.com>
> ---
>  tests/meson.build                  | 28 ++++++++++++++++++++--------
>  tests/{ => vc4}/vc4_create_bo.c    |  0
>  tests/{ => vc4}/vc4_dmabuf_poll.c  |  0
>  tests/{ => vc4}/vc4_label_bo.c     |  0
>  tests/{ => vc4}/vc4_lookup_fail.c  |  0
>  tests/{ => vc4}/vc4_purgeable_bo.c |  0
>  tests/{ => vc4}/vc4_tiling.c       |  0
>  tests/{ => vc4}/vc4_wait_bo.c      |  0
>  tests/{ => vc4}/vc4_wait_seqno.c   |  0
>  9 files changed, 20 insertions(+), 8 deletions(-)
>  rename tests/{ => vc4}/vc4_create_bo.c (100%)
>  rename tests/{ => vc4}/vc4_dmabuf_poll.c (100%)
>  rename tests/{ => vc4}/vc4_label_bo.c (100%)
>  rename tests/{ => vc4}/vc4_lookup_fail.c (100%)
>  rename tests/{ => vc4}/vc4_purgeable_bo.c (100%)
>  rename tests/{ => vc4}/vc4_tiling.c (100%)
>  rename tests/{ => vc4}/vc4_wait_bo.c (100%)
>  rename tests/{ => vc4}/vc4_wait_seqno.c (100%)
> 
> diff --git a/tests/meson.build b/tests/meson.build
> index 12e53e0b..c42efdef 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -83,14 +83,6 @@ test_progs = [
>  	'v3d_get_bo_offset',
>  	'v3d_get_param',
>  	'v3d_mmap',
> -	'vc4_create_bo',
> -	'vc4_dmabuf_poll',
> -	'vc4_label_bo',
> -	'vc4_lookup_fail',
> -	'vc4_purgeable_bo',
> -	'vc4_tiling',
> -	'vc4_wait_bo',
> -	'vc4_wait_seqno',
>  	'vgem_basic',
>  	'vgem_slow',
>  ]
> @@ -258,6 +250,17 @@ msm_progs = [
>  	'msm_submit'
>  ]
>  
> +vc4_progs = [
> +	'vc4_create_bo',
> +	'vc4_dmabuf_poll',
> +	'vc4_label_bo',
> +	'vc4_lookup_fail',
> +	'vc4_purgeable_bo',
> +	'vc4_tiling',
> +	'vc4_wait_bo',
> +	'vc4_wait_seqno',
> +]
> +
As I commented for v3d tests, it would be clearer to me ig the test go
to a subdir /build/tests/vc4/ as I see for amdgpu tests.

>  chamelium_progs = [
>  	'kms_chamelium',
>  ]
> @@ -305,6 +308,15 @@ foreach prog : msm_progs
>  	test_list += prog
>  endforeach
>  
> +foreach prog : vc4_progs
> +	test_executables += executable(prog, join_paths('vc4', prog + '.c'),
> +				       dependencies : test_deps,
> +				       install_dir : libexecdir,
> +				       install_rpath : libexecdir_rpathdir,
> +				       install : true)
> +	test_list += prog
> +endforeach
> +
>  if chamelium.found()
>  	foreach prog : chamelium_progs
>  		test_executables += executable(prog,
> diff --git a/tests/vc4_create_bo.c b/tests/vc4/vc4_create_bo.c
> similarity index 100%
> rename from tests/vc4_create_bo.c
> rename to tests/vc4/vc4_create_bo.c
> diff --git a/tests/vc4_dmabuf_poll.c b/tests/vc4/vc4_dmabuf_poll.c
> similarity index 100%
> rename from tests/vc4_dmabuf_poll.c
> rename to tests/vc4/vc4_dmabuf_poll.c
> diff --git a/tests/vc4_label_bo.c b/tests/vc4/vc4_label_bo.c
> similarity index 100%
> rename from tests/vc4_label_bo.c
> rename to tests/vc4/vc4_label_bo.c
> diff --git a/tests/vc4_lookup_fail.c b/tests/vc4/vc4_lookup_fail.c
> similarity index 100%
> rename from tests/vc4_lookup_fail.c
> rename to tests/vc4/vc4_lookup_fail.c
> diff --git a/tests/vc4_purgeable_bo.c b/tests/vc4/vc4_purgeable_bo.c
> similarity index 100%
> rename from tests/vc4_purgeable_bo.c
> rename to tests/vc4/vc4_purgeable_bo.c
> diff --git a/tests/vc4_tiling.c b/tests/vc4/vc4_tiling.c
> similarity index 100%
> rename from tests/vc4_tiling.c
> rename to tests/vc4/vc4_tiling.c
> diff --git a/tests/vc4_wait_bo.c b/tests/vc4/vc4_wait_bo.c
> similarity index 100%
> rename from tests/vc4_wait_bo.c
> rename to tests/vc4/vc4_wait_bo.c
> diff --git a/tests/vc4_wait_seqno.c b/tests/vc4/vc4_wait_seqno.c
> similarity index 100%
> rename from tests/vc4_wait_seqno.c
> rename to tests/vc4/vc4_wait_seqno.c
> -- 
> 2.38.1
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20221125/6849428c/attachment-0001.sig>


More information about the igt-dev mailing list