[igt-dev] [PATCH 17/76] i915/gem_exec_endless: Close device before exit

[Mauro Carvalho Chehab]

On Fri, 30 Sep 2022 14:25:03 +0200
Kamil Konieczny <kamil.konieczny at linux.intel.com> wrote:

> Hi Mauro,
> 
> On 2022-09-26 at 08:17:22 +0200, Mauro Carvalho Chehab wrote:
> > From: Chris Wilson <chris.p.wilson at intel.com>
> > 
> > Close the device fd before we check for leaks during the atexit
> > handlers.  
> 
> This is somewhat misleading, it only changes type but missed
> actually closing i915 var.
> 
> Maybe some place for future improvement,

When igt_fd_t() is used, there's no need to explicitly close it, as
gcc/clang will use a typed cleanup to close it when the variable
lifetime expires.

> 
> Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> 
> > 
> > Signed-off-by: Chris Wilson <chris.p.wilson at intel.com>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>
> > ---
> > 
> > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> > See [PATCH 00/76] at: https://lore.kernel.org/all/cover.1664173031.git.mchehab@kernel.org/
> > 
> >  tests/i915/gem_exec_endless.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/i915/gem_exec_endless.c b/tests/i915/gem_exec_endless.c
> > index b83d5a2c1480..2c56cc212036 100644
> > --- a/tests/i915/gem_exec_endless.c
> > +++ b/tests/i915/gem_exec_endless.c
> > @@ -28,6 +28,7 @@
> >  #include "igt.h"
> >  #include "igt_device.h"
> >  #include "igt_sysfs.h"
> > +#include "igt_types.h"
> >  #include "sw_sync.h"
> >  
> >  #define MAX_ENGINES 64
> > @@ -341,7 +342,7 @@ static void unpin_rps(int sysfs)
> >  igt_main
> >  {
> >  	const struct intel_execution_engine2 *e;
> > -	int i915 = -1;
> > +	igt_fd_t(i915);
> >  
> >  	igt_skip_on_simulation();
> >  
> > -- 
> > 2.37.3
> >