[igt-dev] [PATCH 01/76] lib: Introduce typed cleanups

[Mauro Carvalho Chehab]

On Tue, 04 Oct 2022 12:17:20 +0200
Janusz Krzysztofik <janusz.krzysztofik at linux.intel.com> wrote:

> > > +#include "igt_core.h"
> > > +#include "igt_types.h"  
> > 
> > Please put here description with IGT_TEST_DESCRIPTION() macro.
> >   
> > > +
> > > +igt_main
> > > +{  
> > 
> > Please put description before test with igt_describe().  
> 
> AFAICS none of lib/tests/*, except igt_describe that needs those clauses 
> because it exercises them, follows that convention.  If you found them 
> helpful then OK, that could be a field for improvement, but that should not 
> block adding new self IGT tests as needed, I believe.

True, but on the other hand, it doesn't hurt adding descriptions. As
such change is trivial enough, I'll add them.
> 
> > 
> > Also copy comment from main test that after running this
> > SIGABORT is intentional.  
> 
> Since this test is added to lib_fail_tests category (see below changes to lib/
> tests/meson.build) then I don't think we need further clarifications.

Same here.

> 
> Thanks,
> Janusz