[igt-dev] [PATCH i-g-t v4 04/77] i915/gem_linear_blits: Close device before exit

[Jani Nikula]

On Wed, 05 Oct 2022, Mauro Carvalho Chehab <mauro.chehab at linux.intel.com> wrote:
> From: Chris Wilson <chris.p.wilson at intel.com>
>
> Close the device fd before we check for leaks during the atexit
> handlers.
>
> Signed-off-by: Chris Wilson <chris.p.wilson at intel.com>
> Reviewed-by: Andrzej Hajda <andrzej.hajda at intel.com>
> Reviewed-by: Nirmoy Das<nirmoy.das at intel.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>
> ---
>  tests/i915/gem_linear_blits.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_linear_blits.c b/tests/i915/gem_linear_blits.c
> index 1fd5b733c3ce..d02751be9232 100644
> --- a/tests/i915/gem_linear_blits.c
> +++ b/tests/i915/gem_linear_blits.c
> @@ -47,6 +47,7 @@
>  #include "i915/gem.h"
>  #include "i915/gem_create.h"
>  #include "igt.h"
> +#include "igt_types.h"
>  
>  IGT_TEST_DESCRIPTION("Test doing many blits with a working set larger than the"
>  		     " aperture size.");
> @@ -236,7 +237,7 @@ igt_main
>  	const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
>  	uint64_t count = 0;
>  	bool do_relocs;
> -	int fd = -1;
> +	igt_fd_t(fd);

I guess igt has long since stopped being written in C, and started being
written in an "igt dialect" of its own... but the constructs still kind
of resemble C.

This doesn't. It looks like a function call but isn't. Looks odd that
it's among the declarations... but it is a declaration.


BR,
Jani.

>  
>  	igt_fixture {
>  		fd = drm_open_driver(DRIVER_INTEL);

-- 
Jani Nikula, Intel Open Source Graphics Center