[igt-dev] [PATCH 2/6] scripts/code_cov_parse_info: fix --only-drm filtering rules

Kamil Konieczny kamil.konieczny at linux.intel.com
Wed Oct 5 19:51:40 UTC 2022


Hi Mauro,

On 2022-09-22 at 10:46:14 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab at kernel.org>
> 
> The --only-drm filtering rules were filtering too much, ending to
> exclude functions on files with "h" on their names. Fix it.
----------------------------------------------------- ^^^^^^^
Please drop this from commit message,
rest looks good so

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

--
Kamil
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>
> ---
> 
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 0/6] at: https://lore.kernel.org/all/cover.1663836123.git.mchehab@kernel.org/
> 
>  scripts/code_cov_parse_info | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/code_cov_parse_info b/scripts/code_cov_parse_info
> index 78b7e2dada5e..037a07e26b1d 100755
> --- a/scripts/code_cov_parse_info
> +++ b/scripts/code_cov_parse_info
> @@ -857,8 +857,8 @@ if ($only_i915) {
>  
>  if ($only_drm) {
>  	# Please keep in sync with the documentation
> -	push @src_exclude_regexes, "trace.*\.h";
> -	push @src_exclude_regexes, "drm.*\.h";
> +	push @src_exclude_regexes, "trace.*\.h\$";
> +	push @src_exclude_regexes, "^/drm/";
>  }
>  
>  $str = open_filter_file($func_filters, \@func_regexes, \@func_exclude_regexes);
> @@ -1051,7 +1051,9 @@ E. g. it will exclude *.h files that match the following regular expressions:
>  
>  And *.h files that don't match:
>  
> -	- drm
> +	- /drm/
> +
> +(e. g. macros and other code outside DRM subsystem)
>  
>  =item B<--only-i915> or B<--only_i915>
>  
> -- 
> 2.37.2
> 


More information about the igt-dev mailing list