[igt-dev] [PATCH i-g-t 1/3] Revert "kms_invalid_mode: Close device before exit"

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Oct 7 15:32:54 UTC 2022


Hi Ville,

On 2022-10-07 at 16:40:27 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> This reverts commit 544fe3ab351e26b39c2db4a8bc9ac2b5032566c4.
> 
> Collateral damage.

You made also two other reverts to this test, maybe this close()
is ok ? This change was part of big series and waited here for
over a week, so please try to send patch series with cover letter
and put there any logs, debug, dumps or links to our CI to see
what happened. Note also that there are other kms tests with
similar change.

If I may suggest please send series with two other reverts to see
if this close() could stay.

Regards,
Kamil

> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  tests/kms_invalid_mode.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/kms_invalid_mode.c b/tests/kms_invalid_mode.c
> index f1c38669860d..0ae98a31fcc2 100644
> --- a/tests/kms_invalid_mode.c
> +++ b/tests/kms_invalid_mode.c
> @@ -306,6 +306,5 @@ igt_main
>  	igt_fixture {
>  		igt_display_fini(&data.display);
>  		igt_reset_connectors();
> -		close(data.drm_fd);
>  	}
>  }
> -- 
> 2.35.1
> 


More information about the igt-dev mailing list