[igt-dev] [i-g-t] tests/kms_atomic_transition: Fix the test execution on internal panels

Karthik B S karthik.b.s at intel.com
Wed Oct 12 10:40:32 UTC 2022


On 10/12/2022 12:33 PM, Bhanuprakash Modem wrote:
> As we are intended to test few cases on internal panels separately,
> fix the logic to execute such tests on internal panels only.
>
> 'TRANSITION_MODESET_FAST' -> should be only for internal panels
> 'TRANSITION_MODESET' -> should be only for external panels
>
> Fixes: 2527ce52 (tests/kms_atomic_transition: Convert tests to dynamic)
> Cc: Karthik B S <karthik.b.s at intel.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
Reviewed-by: Karthik B S <karthik.b.s at intel.com>
> ---
>   tests/kms_atomic_transition.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> index 247b0be4..25757131 100644
> --- a/tests/kms_atomic_transition.c
> +++ b/tests/kms_atomic_transition.c
> @@ -1096,11 +1096,14 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   				 * number of combinations, to avoid long runtimes due to modesets on
>   				 * panels with long power cycle delays.
>   				 */
> -				if (((transition_tests[i].type == TRANSITION_MODESET) ||
> -				     (transition_tests[i].type == TRANSITION_MODESET_FAST)) &&
> +				if ((transition_tests[i].type == TRANSITION_MODESET) &&
>   				    output_is_internal_panel(output))
>   					continue;
>   
> +				if ((transition_tests[i].type == TRANSITION_MODESET_FAST) &&
> +				    !output_is_internal_panel(output))
> +					continue;
> +
>   				if (pipe_count == 2 * count && !data.extended)
>   					break;
>   


More information about the igt-dev mailing list