[igt-dev] [PATCH i-g-t v2] test/kms_plane_cursor: Honour max cursor size

Aurabindo Pillai aurabindo.pillai at amd.com
Thu Oct 13 15:46:27 UTC 2022



On 2022-10-13 11:37, Juha-Pekka Heikkila wrote:
> Hi Aurabindo,
> 
> On 12.10.2022 23.01, Aurabindo Pillai wrote:
>> Skip the tests for cursor sizes that are not supported by the hardware
>>
>> Changes in v2
>> =============
>>
>> * Remove the duplicate definitions for DRM cursor width capability
>> * Check for both cursor width and height when verifying the test 
>> cursor size
>>
>> Signed-off-by: Aurabindo Pillai <aurabindo.pillai at amd.com>
>> ---
>>   tests/kms_plane_cursor.c | 12 ++++++++++++
>>   1 file changed, 12 insertions(+)
>>
>> diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
>> index 43bcaaa4..37fc026c 100644
>> --- a/tests/kms_plane_cursor.c
>> +++ b/tests/kms_plane_cursor.c
>> @@ -30,6 +30,8 @@
>>    * - DRM index indicates z-ordering, higher index = higher z-order
>>    */
>> +static uint64_t max_curw = 64, max_curh = 64;
> I think these would look better as part of data_t structure since all 
> other 'globals' are there.
> 
Sure, will make a v3. Thanks for the review


More information about the igt-dev mailing list