[igt-dev] [PATCH i-g-t] tests/i915/i915_module_load : Use GEM_BUSY instead of SET_CACHE for sanity check

[Kamil Konieczny]

Hi Vikas,

put version number in subject, it should be like vN where
N=number. You can omit it when you send version 1, bute then
any new should be numbered. Remove space after i915_module_load
and ':'. In summary this should be:

[PATCH i-g-t v4] tests/i915/i915_module_load: Use GEM_BUSY instead of SET_CACHE for sanity check
------------ ^ ---------------------------- ^

On 2022-10-19 at 15:53:25 +0530, Vikas Srivastava wrote:
>     Use GEM_BUSY ioctl for sanity check as SET_CACHING ioctl
 ^^^^^
>     is not supported on latest platforms like MTL.
 ^^^^^
Remove white spaces at begin of line.

>     
>     References: VLK-36552
>     
>     Signed-off-by: vikas srivastava <vikas.srivastava at intel.com>
>     Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar at intel.com>
>     Acked-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
>     Cc: Aravind Iddamsetty<aravind.iddamsetty at intel.com>
>     Cc: Fei Yang <fei.yang at intel.com>
>     Cc: Stuart Summers <stuart.summers at intel.com>
>     Cc: Chris Wilson <chris.p.wilson at intel.com>
 ^^^^^
Last place where spaces should be removed.

Please use checkpatch script from Linux kernel for checking
and correcting your patches before sendig them.

>     
> ---
>  tests/i915/i915_module_load.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/i915_module_load.c b/tests/i915/i915_module_load.c
> index 1009a22b..eebb3167 100644
> --- a/tests/i915/i915_module_load.c
> +++ b/tests/i915/i915_module_load.c
> @@ -226,13 +226,13 @@ inject_fault(const char *module_name, const char *opt, int fault)
>  
>  static void gem_sanitycheck(void)
>  {
> -	struct drm_i915_gem_caching args = {};
> +	struct drm_i915_gem_busy args = {};
>  	int i915 = __drm_open_driver(DRIVER_INTEL);
>  	int expected = gem_has_lmem(i915) ? -ENODEV : -ENOENT;
>  	int err;
>  
>  	err = 0;
> -	if (ioctl(i915, DRM_IOCTL_I915_GEM_SET_CACHING, &args))
> +	if (ioctl(i915,DRM_IOCTL_I915_GEM_BUSY, &args))
---------------------- ^
Put space after "," (this one spotted by checkpatch).

Regards,
Kamil

>  		err = -errno;
>  	if (err == expected)
>  		store_all(i915);
> -- 
> 2.25.1
>