[igt-dev] [PATCH i-g-t v3 3/3] lib/crc: Move pipe CRC stuff out from igt_debugfs

Petri Latvala petri.latvala at intel.com
Thu Oct 20 10:08:43 UTC 2022


On Thu, Oct 20, 2022 at 12:52:51PM +0300, Ville Syrjälä wrote:
> On Thu, Oct 20, 2022 at 11:45:27AM +0200, Kamil Konieczny wrote:
> > Hi Ville,
> > 
> > On 2022-10-19 at 19:30:29 +0300, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > You are author and sender, no need for this "From:" line.
> 
> It's an old trick to work around email servers that rewrite the From
> header. I suppose I could get rid of it now that I no longer send
> via such servers, but meh.
> 
> <snip>
> > > diff --git a/lib/igt_pipe_crc.c b/lib/igt_pipe_crc.c
> > > new file mode 100644
> > > index 000000000000..14fe7331f0b0
> > > --- /dev/null
> > > +++ b/lib/igt_pipe_crc.c
> > > @@ -0,0 +1,610 @@
> > > +/*
> > > + * Copyright © 2013 Intel Corporation
> > > + *
> > > + * Permission is hereby granted, free of charge, to any person obtaining a
> > > + * copy of this software and associated documentation files (the "Software"),
> > > + * to deal in the Software without restriction, including without limitation
> > > + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> > > + * and/or sell copies of the Software, and to permit persons to whom the
> > > + * Software is furnished to do so, subject to the following conditions:
> > > + *
> > > + * The above copyright notice and this permission notice (including the next
> > > + * paragraph) shall be included in all copies or substantial portions of the
> > > + * Software.
> > > + *
> > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> > > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> > > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> > > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> > > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> > > + * IN THE SOFTWARE.
> > > + *
> > > + */
> > 
> > Please use SPDX licence here.
> 
> Didn't realize we started to use those in igt. I'll respin.

They are ok to use in new files, not in old files. Season's greetings
from Legal.


-- 
Petri Latvala


More information about the igt-dev mailing list