[igt-dev] [PATCH i-g-t 3/3] tests/api_intel_bb: Add misplaced_blitter test

[Karolina Drobnik]

On 24.10.2022 08:46, Zbigniew Kempczyński wrote:
> On Fri, Oct 21, 2022 at 10:54:43AM +0200, Karolina Drobnik wrote:
>> Exercise intel_bb with a custom context engines layout.
>>
>> Signed-off-by: Karolina Drobnik <karolina.drobnik at intel.com>
>> ---
>>   tests/i915/api_intel_bb.c | 34 ++++++++++++++++++++++++++++++++++
>>   1 file changed, 34 insertions(+)
>>
>> diff --git a/tests/i915/api_intel_bb.c b/tests/i915/api_intel_bb.c
>> index 6ba1fd1b..42959880 100644
>> --- a/tests/i915/api_intel_bb.c
>> +++ b/tests/i915/api_intel_bb.c
>> @@ -1209,6 +1209,36 @@ static void full_batch(struct buf_ops *bops)
>>   	intel_bb_destroy(ibb);
>>   }
>>
>> +static void misplaced_blitter(struct buf_ops *bops)
>> +{
>> +	int i915 = buf_ops_get_fd(bops);
>> +	struct intel_bb *ibb;
>> +
>> +	gem_require_contexts(i915);
>> +
>> +	/* Use custom configuration with blitter at index 0 */
>> +	const intel_ctx_cfg_t cfg = (intel_ctx_cfg_t) {
>> +			.num_engines = 2,
>> +			.engines = {
>> +				{ .engine_class = I915_ENGINE_CLASS_COPY,
>> +				  .engine_instance = 0
>> +				},
>> +				{ .engine_class = I915_ENGINE_CLASS_RENDER,
>> +				  .engine_instance = 0
>> +				},
>> +			},
>> +		};
>> +	const intel_ctx_t *ctx = intel_ctx_create(i915, &cfg);
>> +
>> +	ibb = intel_bb_create_with_context(i915, ctx->id, &ctx->cfg, PAGE_SIZE);
>> +
>> +	intel_bb_emit_bbe(ibb);
>> +	intel_bb_flush_blit(ibb);
> 
> BBE will work on each engine, can you prove it was executed on blitter?

Good point. We should add an additional instruction that would work only 
on blitter. Will correct it, thanks.

All the best,
Karolina

> --
> Zbigniew
> 
>> +
>> +	intel_bb_destroy(ibb);
>> +	intel_ctx_destroy(i915, ctx);
>> +}
>> +
>>   static int render(struct buf_ops *bops, uint32_t tiling, bool do_reloc,
>>   		  uint32_t width, uint32_t height)
>>   {
>> @@ -1581,6 +1611,10 @@ igt_main_args("dpibc:", NULL, help_str, opt_handler, NULL)
>>   	igt_subtest("full-batch")
>>   		full_batch(bops);
>>
>> +	igt_describe("Execute intel_bb with set of engines provided by userspace");
>> +	igt_subtest("misplaced-blitter")
>> +		misplaced_blitter(bops);
>> +
>>   	igt_subtest_with_dynamic("render") {
>>   		for (i = 0; i < ARRAY_SIZE(tests); i++) {
>>   			const struct test *t = &tests[i];
>> --
>> 2.25.1