[igt-dev] [PATCH] tests/kms_dp_aux_dev: Check DP connection only before tests

[Petri Latvala]

On Tue, Oct 25, 2022 at 08:16:15PM -0600, Alex Hung wrote:
> Without DP port connected, kernel reports "Too many retries"
> that indicates no sink to respond. This is the same across GPUs.
> 
> amdgpu ... DM aux hw bus 2: Too many retries, giving up. First error: -5
> i915 ... AUX C/DDI C/PHY C: Too many retries, giving up. First error: -110
> 
> In addition, the test can result time out such as below:
> 
> /dev/drm_dp_aux0: Connection timed out
> /dev/drm_dp_aux1: Connection timed out
> 
> As a result, checking DP connection alone should be sufficient.
> 
> Signed-off-by: Alex Hung <alex.hung at amd.com>
> ---
>  tests/kms_dp_aux_dev.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tests/kms_dp_aux_dev.c b/tests/kms_dp_aux_dev.c
> index ed9dd510..7fce74a4 100644
> --- a/tests/kms_dp_aux_dev.c
> +++ b/tests/kms_dp_aux_dev.c
> @@ -53,8 +53,7 @@ static bool test(int drm_fd, uint32_t connector_id)
>  	drmModeFreeConnector(connector);
>  	igt_assert(dir_fd >= 0);
>  
> -	if (connector->connection != DRM_MODE_CONNECTED &&
> -	    is_mst_connector(drm_fd, connector_id)) {
> +	if (connector->connection != DRM_MODE_CONNECTED) {
>  		close(dir_fd);
>  		return false;
>  	}


Bhanuprakash, Swati, you wrote/reviewed this piece of code, please review
this patch.


-- 
Petri Latvala