[igt-dev] [PATCH i-g-t v2 7/7] runner: Disable socket communications for now

Petri Latvala petri.latvala at intel.com
Mon Oct 31 10:24:34 UTC 2022


Currently, having i915 CI systems test the socket communications when
testing is impossible. If a test hangs completely, the incomplete set
of results are processed into results.json with an older IGT version
from a previous post-merge build, which is unable to parse socket
communications. Disable them for now.

This commit will get reverted after suitable testing has been possible
to execute.

v2: Rename the enable var, explain its presence further in a comment
    (Kamil)

Signed-off-by: Petri Latvala <petri.latvala at intel.com>
Acked-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
---
 runner/executor.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/runner/executor.c b/runner/executor.c
index 669e8524..a79a34e0 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -1659,7 +1659,14 @@ static int execute_next_entry(struct execute_state *state,
 
 		sigprocmask(SIG_UNBLOCK, sigmask, NULL);
 
-		if (socketfd >= 0 && !getenv("IGT_RUNNER_DISABLE_SOCKET_COMMUNICATION")) {
+		if (socketfd >= 0 && !getenv("IGT_RUNNER_DISABLE_SOCKET_COMMUNICATION") &&
+		    getenv("IGT_RUNNER_ENABLE_SOCKET_COMMUNICATION_FIXME")) {
+			/*
+			 * The variable for enabling socket comms is
+			 * temporary. Do not use unless you really
+			 * know what you're doing. Requiring it will
+			 * go away later.
+			 */
 			snprintf(envstring, sizeof(envstring), "%d", socketfd);
 			setenv("IGT_RUNNER_SOCKET_FD", envstring, 1);
 		}
-- 
2.30.2



More information about the igt-dev mailing list