[igt-dev] [PATCH i-g-t] tests/kms_async_flips: Enable async flip on linear buffer

[Murthy, Arun R]

> -----Original Message-----
> From: Latvala, Petri <petri.latvala at intel.com>
> Sent: Wednesday, August 31, 2022 2:38 PM
> To: Murthy, Arun R <arun.r.murthy at intel.com>
> Cc: igt-dev at lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_async_flips: Enable async flip on
> linear buffer
> 
> On Mon, Aug 29, 2022 at 03:01:47PM +0530, Arun R Murthy wrote:
> > On Intel Gen platforms >= GEN12, Async on linear buffer is supported,
> > hence enabling test for the same.
> >
> > Signed-off-by: Arun R Murthy <arun.r.murthy at intel.com>
> > ---
> >  tests/kms_async_flips.c | 18 +++++++++++++++++-
> >  1 file changed, 17 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_async_flips.c b/tests/kms_async_flips.c index
> > 695aea74..610cad34 100644
> > --- a/tests/kms_async_flips.c
> > +++ b/tests/kms_async_flips.c
> > @@ -61,6 +61,7 @@ typedef struct {
> >  	bool extended;
> >  	enum pipe pipe;
> >  	bool alternate_sync_async;
> > +	bool is_linear_buffer;
> >  } data_t;
> >
> >  static void flip_handler(int fd_, unsigned int sequence, unsigned int
> > tv_sec, @@ -125,6 +126,7 @@ static void make_fb(data_t *data, struct
> > igt_fb *fb,
> >
> >  	if (is_i915_device(data->drm_fd)) {
> >  		igt_create_fb(data->drm_fd, width, height,
> DRM_FORMAT_XRGB8888,
> > +			      data->is_linear_buffer ?
> DRM_FORMAT_MOD_LINEAR :
> >  			      I915_FORMAT_MOD_X_TILED, fb);
> >  		igt_draw_fill_fb(data->drm_fd, fb, 0x88);
> >  	} else {
> > @@ -594,14 +596,28 @@ igt_main_args("e", NULL, help_str, opt_handler,
> &data)
> >  		igt_fixture
> >  			require_monotonic_timestamp(data.drm_fd);
> >
> > -		igt_describe("Wait for page flip events in between successive
> asynchronous flips");
> > +		igt_describe("Wait for page flip events in between successive
> > +asynchronous flips on X Tiled buffer");
> >  		igt_subtest_with_dynamic("async-flip-with-page-flip-events")
> {
> >  			data.alternate_sync_async = false;
> > +			data.is_linear_buffer = false;
> >  			run_test(&data, test_async_flip);
> >  		}
> >
> > +		igt_describe("Wait for page flip events in between successive
> asynchronous flips on Linear buffer");
> > +		igt_subtest_with_dynamic("async-flip-with-page-flip-events-
> linear") {
> > +			data.alternate_sync_async = false;
> > +			data.is_linear_buffer = true;
> > +			if(is_i915_device(data.drm_fd)) {
> > +				uint32_t devid =
> intel_get_drm_devid(data.drm_fd);
> > +				igt_skip_on_f(!AT_LEAST_GEN(devid, 12),
> > +						"Async on Linear buffer not
> supported");
> 
> This text needs a newline character at the end.
> 
Sorry missed it, Done added!

Thanks and Regards,
Arun R Murthy
--------------------