[igt-dev] [PATCH i-g-t 10/12] i915/gem_mmap_offset: Check all mmap types reject invalid objects

[Zbigniew Kempczyński]

On Thu, Sep 01, 2022 at 01:44:40PM +0200, Zbigniew Kempczyński wrote:
> From: Chris Wilson <chris.p.wilson at linux.intel.com>
> 
> Extend the bad_object negative subtest to cover all mmap types.
> 
> Signed-off-by: Chris Wilson <chris.p.wilson at linux.intel.com>
> ---
>  tests/i915/gem_mmap_offset.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/i915/gem_mmap_offset.c b/tests/i915/gem_mmap_offset.c
> index 40daa53061..7c663f1074 100644
> --- a/tests/i915/gem_mmap_offset.c
> +++ b/tests/i915/gem_mmap_offset.c
> @@ -121,15 +121,17 @@ static void bad_object(int i915)
>  	handles[i] = real_handle + 1;
>  
>  	for (; i >= 0; i--) {
> -		struct drm_i915_gem_mmap_offset arg = {
> -			.handle = handles[i],
> -			.flags = I915_MMAP_OFFSET_WB,
> -		};
> +		for_each_mmap_offset_type(i915, t) {
> +			struct drm_i915_gem_mmap_offset arg = {
> +				.handle = handles[i],
> +				.flags = t->type,
> +			};
>  
> -		igt_debug("Trying MMAP IOCTL with handle %x\n",
> -			  handles[i]);
> -		igt_assert_eq(mmap_offset_ioctl(i915, &arg),
> -			      -ENOENT);
> +			igt_debug("Trying MMAP IOCTL[%s] with handle %x\n",
> +				  t->name, handles[i]);
> +			igt_assert_eq(mmap_offset_ioctl(i915, &arg),
> +				      -ENOENT);
> +		}
>  	}
>  
>  	gem_close(i915, real_handle);
> -- 
> 2.34.1
>

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew