[igt-dev] [PATCH i-g-t 08/23] i915/perf: Define OA report types

[Lionel Landwerlin]

On 23/08/2022 21:30, Umesh Nerlige Ramappa wrote:
> Differentiate between OAG and OAR format types for tests like
> oa-formats.
>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
> ---
>   tests/i915/perf.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/tests/i915/perf.c b/tests/i915/perf.c
> index 19c33324..b61dd6e2 100644
> --- a/tests/i915/perf.c
> +++ b/tests/i915/perf.c
> @@ -95,6 +95,13 @@ struct accumulator {
>   	uint64_t deltas[MAX_RAW_OA_COUNTERS];
>   };
>   
> +enum {
> +	OAG,
> +	OAR,
> +
> +	MAX_OA_TYPE,
> +};
> +
>   struct oa_format {
>   	const char *name;
>   	size_t size;
> @@ -110,6 +117,7 @@ struct oa_format {
>   	int n_b;
>   	int c_off;
>   	int n_c;
> +	int oa_type;
>   };
>   
>   static struct oa_format hsw_oa_formats[I915_OA_FORMAT_MAX] = {
> @@ -1539,6 +1547,9 @@ test_oa_formats(void)
>   		if (!format.name) /* sparse, indexed by ID */
>   			continue;
>   
> +		if (format.oa_type != OAG) /* sparse, indexed by ID */
> +			continue;
> +

I can't make sense of this comment.

Also you're not going to test OAR reports?


>   		igt_debug("Checking OA format %s\n", format.name);
>   
>   		open_and_read_2_oa_reports(i,