[igt-dev] [PATCH i-g-t v1] tests/kms_chamelium: Fix common suspend/hibernate

[Joshi, Kunal1]

>> @@ -577,19 +577,19 @@ test_suspend_resume_hpd_common(data_t *data, enum igt_suspend_state state,
>>  	for (p = 0; p < data->port_count; p++) {
>>  		port = data->ports[p];
>>  		igt_debug("Testing port %s\n", chamelium_port_get_name(port));
>> -	}
>>  
>> -	igt_modeset_disable_all_outputs(&data->display);
>> -	chamelium_reset_state(&data->display, data->chamelium, NULL,
>> -			      data->ports, data->port_count);
>> +		igt_modeset_disable_all_outputs(&data->display);
>> +		chamelium_reset_state(&data->display, data->chamelium, NULL,
>> +				      data->ports, data->port_count);
>>  
>> -	/* Make sure we notice new connectors after resuming */
>> -	try_suspend_resume_hpd(data, NULL, state, test, mon, false);
>> +		/* Make sure we notice new connectors after resuming */
>> +		try_suspend_resume_hpd(data, NULL, state, test, mon, false);
>>  
>> -	/* Now make sure we notice disconnected connectors after resuming */
>> -	try_suspend_resume_hpd(data, NULL, state, test, mon, true);
>> +		/* Now make sure we notice disconnected connectors after resuming */
>> +		try_suspend_resume_hpd(data, NULL, state, test, mon, true);
>>  
>> -	igt_cleanup_uevents(mon);
>> +		igt_cleanup_uevents(mon);
>> +	}

>What are these changes here? Did you (accidentally?) make the suspend-resumes repeated > for every port?

> --
> Petri Latvala

Got you,
try_suspend_resume_hpd already schedules hotplug if NULL passed as port,
will remove these changes in v2.

Thanks, Petri.