[igt-dev] [PATCH i-g-t] tests/kms_addfb_basic: Skip y-tile-legacy subtest on platforms w/o fences

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Mon Sep 12 08:24:04 UTC 2022


Look ok to me, that one new incomplete in ci results I can't see how it 
would relate to this change.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

On 9.9.2022 15.24, Karthik B S wrote:
> As set/get_tiling ioctls are not supported on platforms without fences,
> this test will fail. Add check to skip the subtest on these platforms.
> 
> Signed-off-by: Karthik B S <karthik.b.s at intel.com>
> ---
>   tests/kms_addfb_basic.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 6b2323a9..afb4bdf6 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -387,6 +387,7 @@ static void tiling_tests(int fd)
>   		f.pitches[0] = 1024*4;
>   		igt_subtest("basic-y-tiled-legacy") {
>   			igt_require(!gem_has_lmem(fd));
> +			igt_require(gem_available_fences(fd) > 0);
>   			f.handles[0] = tiled_y_bo;
>   
>   			igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&



More information about the igt-dev mailing list