[igt-dev] [PATCH i-g-t] tests/kms_color_chamelium: Fix port_idx

Kunal Joshi kunal1.joshi at intel.com
Mon Sep 12 09:06:10 UTC 2022


Since port id can also be 0, return -1 instead

Cc: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
Signed-off-by: Kunal Joshi <kunal1.joshi at intel.com>
---
 tests/chamelium/kms_color_chamelium.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/chamelium/kms_color_chamelium.c b/tests/chamelium/kms_color_chamelium.c
index 678931aa..9aaa1245 100644
--- a/tests/chamelium/kms_color_chamelium.c
+++ b/tests/chamelium/kms_color_chamelium.c
@@ -443,7 +443,7 @@ static int test_setup(data_t *data, enum pipe p)
 		}
 	}
 
-	return 0;
+	return -1;
 }
 
 static void
@@ -452,7 +452,7 @@ run_gamma_degamma_tests_for_pipe(data_t *data, enum pipe p,
 {
 	int port_idx = test_setup(data, p);
 
-	igt_require(port_idx);
+	igt_require(port_idx != -1);
 
 	data->color_depth = 8;
 	data->drm_format = DRM_FORMAT_XRGB8888;
@@ -476,7 +476,7 @@ run_ctm_tests_for_pipe(data_t *data, enum pipe p,
 	};
 	int port_idx = test_setup(data, p);
 
-	igt_require(port_idx);
+	igt_require(port_idx != -1);
 	/*
 	 * CherryView generates values on 10bits that we
 	 * produce with an 8 bits per color framebuffer.
@@ -531,7 +531,7 @@ run_limited_range_ctm_test_for_pipe(data_t *data, enum pipe p,
 {
 	int port_idx = test_setup(data, p);
 
-	igt_require(port_idx);
+	igt_require(port_idx != -1);
 	igt_require(igt_output_has_prop(data->output, IGT_CONNECTOR_BROADCAST_RGB));
 
 	data->color_depth = 8;
-- 
2.17.1



More information about the igt-dev mailing list