[igt-dev] [PATCH i-g-t v1] tests/kms_color_chamelium: Fix port_idx check

Modem, Bhanuprakash bhanuprakash.modem at intel.com
Thu Sep 15 09:34:26 UTC 2022


On Thu-15-09-2022 02:56 pm, Kunal Joshi wrote:
> chamelium has a port with id 0, so return -1 instead.
> 
> Cc: Modem Bhanuprakash <bhanuprakash.modem at intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi at intel.com>
> ---
>   tests/chamelium/kms_color_chamelium.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/chamelium/kms_color_chamelium.c b/tests/chamelium/kms_color_chamelium.c
> index 678931aa..05a06155 100644
> --- a/tests/chamelium/kms_color_chamelium.c
> +++ b/tests/chamelium/kms_color_chamelium.c
> @@ -443,7 +443,7 @@ static int test_setup(data_t *data, enum pipe p)
>   		}
>   	}
>   
> -	return 0;
> +	return -1;
>   }
>   
>   static void
> @@ -452,7 +452,7 @@ run_gamma_degamma_tests_for_pipe(data_t *data, enum pipe p,
>   {
>   	int port_idx = test_setup(data, p);
>   
> -	igt_require(port_idx);
> +	igt_require(port_idx >= 0);

We need this change at run_ctm_tests_for_pipe() & 
run_limited_range_ctm_test_for_pipe() too.

- Bhanu

>   
>   	data->color_depth = 8;
>   	data->drm_format = DRM_FORMAT_XRGB8888;



More information about the igt-dev mailing list