[igt-dev] [PATCH i-g-t 1/4] tests/core_hotunplug: Free mem allocated by igt_audio_driver_unload

Mauro Carvalho Chehab mauro.chehab at linux.intel.com
Tue Sep 20 05:04:20 UTC 2022


On Tue, 13 Sep 2022 14:04:38 +0200
Janusz Krzysztofik <janusz.krzysztofik at linux.intel.com> wrote:

> Since we pass NULL to igt_audio_driver_unload(), realloc() it calls
> allocates new memory for us.  Free it each time we no longer need it,
> before dropping a pointer to it, to avoid memory leaking.
> 
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik at linux.intel.com>

Reviewed-by: Mauro Carvalho Chehab <mchehab at kernel.org>

> ---
>  tests/core_hotunplug.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
> index a0d29b799a..733ea8efb0 100644
> --- a/tests/core_hotunplug.c
> +++ b/tests/core_hotunplug.c
> @@ -187,6 +187,7 @@ static void driver_bind(struct hotunplug *priv, int timeout)
>  	if (priv->snd_driver) {
>  		igt_info("Realoading %s\n", priv->snd_driver);
>  		igt_kmod_load(priv->snd_driver, NULL);
> +		free(priv->snd_driver);
>  		priv->snd_driver = NULL;
>  	}
>  }


More information about the igt-dev mailing list