[igt-dev] [PATCH i-g-t] tests/i915/kms_busy: Test cleanup

[Modem, Bhanuprakash]

On Tue-06-09-2022 07:36 pm, Nidhi Gupta wrote:
> Sanitize the system state before starting the subtest.
> 
> Signed-off-by: Nidhi Gupta <nidhi1.gupta at intel.com>
> ---
>   tests/i915/kms_busy.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/tests/i915/kms_busy.c b/tests/i915/kms_busy.c
> index 99a07c2a..6bb9dbec 100644
> --- a/tests/i915/kms_busy.c
> +++ b/tests/i915/kms_busy.c
> @@ -144,6 +144,8 @@ static void test_flip(igt_display_t *dpy, int pipe, bool modeset)
>   	igt_output_t *output;
>   	int timeout;
>   
> +	igt_display_reset(dpy);
> +
>   	if (modeset)
>   		igt_require(dpy->is_atomic);

Please avoid using igt_require*() & igt_skip*() inside the dynamic
subtest, instead don't run the subtest.

- Bhanu

>   
> @@ -230,6 +232,7 @@ static void test_hang(igt_display_t *dpy,
>   	igt_output_t *output;
>   	igt_plane_t *primary;
>   
> +	igt_display_reset(dpy);
>   	output = set_fb_on_crtc(dpy, pipe, &fb[0]);
>   	igt_display_commit2(dpy, COMMIT_ATOMIC);
>   	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> @@ -274,6 +277,8 @@ static void test_pageflip_modeset_hang(igt_display_t *dpy, enum pipe pipe)
>   	igt_spin_t *t;
>   	uint64_t ahnd = get_reloc_ahnd(dpy->drm_fd, 0);
>   
> +	igt_display_reset(dpy);
> +	
>   	output = set_fb_on_crtc(dpy, pipe, &fb);
>   	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
>