[igt-dev] [i-g-t] tests/kms_color: Fix ctm-0.* tests

[Modem, Bhanuprakash]

On Mon-26-09-2022 03:02 pm, Ville Syrjälä wrote:
> On Sun, Sep 25, 2022 at 09:30:50PM +0530, Bhanuprakash Modem wrote:
>> As we are testing with a few values around the expected result
>> because of the hardware rounded values, fix the logic to generate
>> the expected values to deal with those hardware rounding issues.
>>
>> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
>> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
>> ---
>>   tests/kms_color.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/kms_color.c b/tests/kms_color.c
>> index ab285af8..2804bde8 100644
>> --- a/tests/kms_color.c
>> +++ b/tests/kms_color.c
>> @@ -770,7 +770,7 @@ run_ctm_tests_for_pipe(data_t *data, enum pipe p,
>>   			expected_colors[0].r =
>>   				expected_colors[1].g =
>>   				expected_colors[2].b =
>> -				0.5 + delta * (i - 2);
>> +				ctm[0] + delta * (i - (iter / 2));
> 
> The name 'iter' is not a particularly great choice here.
> Based on that name I would expect it to be an iterator
> of some sort.
> 
> Another thing I don't really like here is that this guy is
> mutating expected_colors, which was passed all the way from
> the top and really should be const (since the whole ctm_tests[]
> should be const). would be much better to have a local thing
> to mutate here.

Sure, I'll float a new patch to include this.

- Bhanu

> 
>>   			if (test_pipe_ctm(data, data->primary, red_green_blue,
>>   					  expected_colors, ctm)) {
>>   				success = true;
>> -- 
>> 2.37.3
>