[igt-dev] [PATCH] tests/kms_plane_cursor: update pipe to output for each test

Mark Yacoub markyacoub at chromium.org
Mon Sep 26 15:28:10 UTC 2022


On Thu, Sep 22, 2022 at 9:28 PM Alex Hung <alex.hung at amd.com> wrote:
>
> Pipe/pipe_id changes during test executions, and it
> needs updating in test_cursor.
>
> Resolved input/output error when reading CRC:
>
> Test assertion failure function igt_pipe_crc_start ...
> Failed assertion: pipe_crc->crc_fd != -1
> Last errno: 5, Input/output error
>
> Signed-off-by: Alex Hung <alex.hung at amd.com>
Reviewed-by: Mark Yacoub <markyacoub at chromium.org>
> ---
>  tests/kms_plane_cursor.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tests/kms_plane_cursor.c b/tests/kms_plane_cursor.c
> index 6b7e5cef..d29dc327 100644
> --- a/tests/kms_plane_cursor.c
> +++ b/tests/kms_plane_cursor.c
> @@ -87,8 +87,6 @@ static void test_init(data_t *data, enum pipe pipe_id, igt_output_t *output)
>         data->pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe_id,
>                                           INTEL_PIPE_CRC_SOURCE_AUTO);
>
> -       igt_output_set_pipe(data->output, data->pipe_id);
> -
>         /* Overlay rectangle for a rect in the center of the screen */
>         data->or.x = data->mode->hdisplay / 4;
>         data->or.y = data->mode->vdisplay / 4;
> @@ -244,6 +242,7 @@ static void test_cursor(data_t *data, int size, unsigned int flags)
>                             1.0, 0.0, 1.0, &data->cfb);
>
>         igt_plane_set_fb(data->primary, &data->pfb);
> +       igt_output_set_pipe(data->output, data->pipe_id);
>         igt_display_commit2(&data->display, COMMIT_ATOMIC);
>
>         test_cursor_spots(data, size, flags);
> --
> 2.34.1
>


More information about the igt-dev mailing list