[igt-dev] [PATCH i-g-t v1 2/5] tests/i915/kms_pipe_b_c_ivb.c: test cleanup

[B, Jeevan]

Hi Kunal, 

> -----Original Message-----
> From: Joshi, Kunal1 <kunal1.joshi at intel.com>
> Sent: Tuesday, September 27, 2022 12:23 AM
> To: igt-dev at lists.freedesktop.org
> Cc: Joshi, Kunal1 <kunal1.joshi at intel.com>; B, Jeevan <jeevan.b at intel.com>
> Subject: [PATCH i-g-t v1 2/5] tests/i915/kms_pipe_b_c_ivb.c: test cleanup
> 
> -> Sanitize the state before starting the subtest close drm_fd
> 
> Cc: Jeevan B <jeevan.b at intel.com>
> Signed-off-by: Kunal Joshi <kunal1.joshi at intel.com>
> ---
>  tests/i915/kms_pipe_b_c_ivb.c | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/tests/i915/kms_pipe_b_c_ivb.c b/tests/i915/kms_pipe_b_c_ivb.c
> index 5823ae2a..4f49d7b2 100644
> --- a/tests/i915/kms_pipe_b_c_ivb.c
> +++ b/tests/i915/kms_pipe_b_c_ivb.c
> @@ -142,6 +142,12 @@ test_dpms(data_t *data)
>  	igt_output_t *output1, *output2;
>  	int ret;
> 
> +	/*
> +	 * Reset basic pipes, connectors and planes on
> +	 * @display back to default values.
> +	 */
> +	igt_display_reset(&data->display);

Can we call this inside fixture ? 

Thanks 
Jeevan B 

> +
>  	find_outputs(data, &output1, &output2);
> 
>  	igt_info("Pipe %s will use connector %s\n", @@ -164,6 +170,12 @@
> test_lane_reduction(data_t *data)
>  	igt_output_t *output1, *output2;
>  	int ret;
> 
> +	/*
> +	 * Reset basic pipes, connectors and planes on
> +	 * @display back to default values.
> +	 */
> +	igt_display_reset(&data->display);
> +
>  	find_outputs(data, &output1, &output2);
> 
>  	igt_info("Pipe %s will use connector %s\n", @@ -187,6 +199,12 @@
> test_disable_pipe_B(data_t *data)
>  	igt_output_t *output1, *output2;
>  	int ret;
> 
> +	/*
> +	 * Reset basic pipes, connectors and planes on
> +	 * @display back to default values.
> +	 */
> +	igt_display_reset(&data->display);
> +
>  	find_outputs(data, &output1, &output2);
> 
>  	igt_info("Pipe %s will use connector %s\n", @@ -213,6 +231,12 @@
> test_from_C_to_B_with_3_lanes(data_t *data)
>  	igt_output_t *output1, *output2;
>  	int ret;
> 
> +	/*
> +	 * Reset basic pipes, connectors and planes on
> +	 * @display back to default values.
> +	 */
> +	igt_display_reset(&data->display);
> +
>  	find_outputs(data, &output1, &output2);
> 
>  	igt_info("Pipe %s will use connector %s\n", @@ -236,6 +260,12 @@
> test_fail_enable_pipe_C_while_B_has_3_lanes(data_t *data)
>  	igt_output_t *output1, *output2;
>  	int ret;
> 
> +	/*
> +	 * Reset basic pipes, connectors and planes on
> +	 * @display back to default values.
> +	 */
> +	igt_display_reset(&data->display);
> +
>  	find_outputs(data, &output1, &output2);
> 
>  	igt_info("Pipe %s will use connector %s\n", @@ -291,5 +321,6 @@
> igt_main
> 
>  	igt_fixture {
>  		igt_display_fini(&data.display);
> +		close(data.drm_fd);
>  	}
>  }
> --
> 2.25.1