[igt-dev] [PATCH] tests/kms_plane_multiple: turn off pipe if all planes are off

[Mark Yacoub]

On Mon, Sep 26, 2022 at 5:50 PM Alex Hung <alex.hung at amd.com> wrote:
>
> amdgpu rejects when crtc is on + all planes are off, and it
> is necessary to turn off crtc when all planes are off.
>
> This is revised from https://patchwork.freedesktop.org/series/80904/
>
> Signed-off-by: Alex Hung <alex.hung at amd.com>
> ---
>  tests/kms_plane_multiple.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
> index cbe8c189..6ebde8b0 100644
> --- a/tests/kms_plane_multiple.c
> +++ b/tests/kms_plane_multiple.c
> @@ -311,6 +311,8 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
>                 for_each_plane_on_pipe(&data->display, pipe, plane)
>                         igt_plane_set_fb(plane, NULL);
>
> +               if (is_amdgpu_device(data->drm_fd))
what if we apply it for everyone else?
> +                       igt_output_set_pipe(output, PIPE_NONE);
>                 igt_display_commit2(&data->display, COMMIT_ATOMIC);
>
>                 for (int x = 0; x < c; x++)
> @@ -344,6 +346,8 @@ test_plane_position_with_output(data_t *data, enum pipe pipe,
>                 for_each_plane_on_pipe(&data->display, pipe, plane)
>                         igt_plane_set_fb(plane, NULL);
>
> +               if (is_amdgpu_device(data->drm_fd))
ditto - would it hurt?
> +                       igt_output_set_pipe(output, PIPE_NONE);
>                 igt_display_commit2(&data->display, COMMIT_ATOMIC);
>
>                 for (int x = 0; x < c; x++)
> --
> 2.34.1
>