[igt-dev] [PATCH RFC 2/2] lib/igt_core: print card sysfs node at subtest results

[Kamil Konieczny]

Hi Mauro,

On 2022-09-28 at 12:43:20 +0300, Petri Latvala wrote:
> On Wed, Sep 28, 2022 at 10:58:42AM +0200, Mauro Carvalho Chehab wrote:
> > From: Mauro Carvalho Chehab <mchehab at kernel.org>
> > 
> > This helps to identify what GPU failed on multi-GPU tests.
> 
> And completely breaks igt_runner when it tries to parse the result
> logs.
> 
> 
> -- 
> Petri Latvala

First thing is to decide where such info should be printed,
imho it is worth to have it with maybe some new IGT_PRINT_GPU
environment var ?
This var can configure how it will work, what it will store,
where to print message about used GPU, on begin of error message
or at end.

If not defined, we should not print any additional info.

btw I did not received you RFC from mailist server,
are there any known problems with ML ?

Second thought, after reading RFC on patchwork, please put your
comments from cover letter into commit description in first
patch so it will be in git history.

Regards,
Kamil
> 
> 
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>
> > ---
> >  lib/igt_core.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/lib/igt_core.c b/lib/igt_core.c
> > index 0d018758ce38..6575eabca027 100644
> > --- a/lib/igt_core.c
> > +++ b/lib/igt_core.c
> > @@ -1481,6 +1481,9 @@ __noreturn static void exit_subtest(const char *result)
> >  
> >  	igt_gettime(&now);
> >  
> > +	if (gpu_string)
> > +		igt_info("%s: ", gpu_string);
> > +
> >  	igt_info("%s%s %s: %s (%.3fs)%s\n",
> >  		 (!__igt_plain_output) ? "\x1b[1m" : "",
> >  		 subtest_text, *subtest_name, result,
> > -- 
> > 2.37.3
> >