[igt-dev] [i-g-t V5 23/52] tests/kms_plane_alpha_blend: Add support for Bigjoiner

Swati Sharma swati2.sharma at intel.com
Fri Sep 30 08:27:30 UTC 2022


LGTM
Reviewed-by:  Swati Sharma <swati2.sharma at intel.com>

On 28-Sep-22 4:50 PM, Bhanuprakash Modem wrote:
> This patch will add a check to Skip the subtest if a selected pipe/output
> combo won't support Bigjoiner or 8K mode.
> 
> Example:
> * Pipe-D wont support a mode > 5K
> * To use 8K mode on a pipe then consecutive pipe must be available & free.
> 
> V2: - Use updated helper name
> V3: - Rebase
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> ---
>   tests/kms_plane_alpha_blend.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_plane_alpha_blend.c b/tests/kms_plane_alpha_blend.c
> index f122066d..156005d5 100644
> --- a/tests/kms_plane_alpha_blend.c
> +++ b/tests/kms_plane_alpha_blend.c
> @@ -171,9 +171,6 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe)
>   	int w, h;
>   	igt_plane_t *primary = igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY);
>   
> -	igt_display_reset(display);
> -	igt_output_set_pipe(output, pipe);
> -
>   	/* create the pipe_crc object for this pipe */
>   	igt_pipe_crc_free(data->pipe_crc);
>   	data->pipe_crc = igt_pipe_crc_new(data->gfx_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO);
> @@ -616,6 +613,12 @@ static void run_subtests(data_t *data)
>   
>   		igt_subtest_with_dynamic(subtests[i].name) {
>   			for_each_pipe_with_single_output(&data->display, pipe, output) {
> +				igt_display_reset(&data->display);
> +
> +				igt_output_set_pipe(output, pipe);
> +				if (!i915_pipe_output_combo_valid(&data->display))
> +					continue;
> +
>   				prepare_crtc(data, output, pipe);
>   				if (!pipe_check(data, pipe, subtests[i].blend, subtests[i].must_multiply))
>   					continue;

-- 
~Swati Sharma


More information about the igt-dev mailing list