[igt-dev] [i-g-t V4 02/52] lib/igt_kms: Bigjoiner check in max_bpc constraint

Swati Sharma swati2.sharma at intel.com
Fri Sep 30 08:30:56 UTC 2022


LGTM
Reviewed-by:  Swati Sharma <swati2.sharma at intel.com>

On 22-Sep-22 9:29 PM, Bhanuprakash Modem wrote:
> There is a possibility of commit failure if the selected pipe/output
> won't support Bigjoiner or 8K. So we need to handle this case.
> 
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> ---
>   lib/igt_kms.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 5fdb67fc..a3ed5ec9 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -5713,6 +5713,11 @@ bool igt_max_bpc_constraint(igt_display_t *display, enum pipe pipe,
>   
>   	for_each_connector_mode(output) {
>   		igt_output_override_mode(output, &connector->modes[j__]);
> +
> +		if (is_i915_device(display->drm_fd) &&
> +		    !igt_check_bigjoiner_support(display))
> +			continue;
> +
>   		igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
>   
>   		if (!igt_check_output_bpc_equal(display->drm_fd, pipe,

-- 
~Swati Sharma


More information about the igt-dev mailing list