[igt-dev] [PATCH 15/76] i915/gem_workarounds: Close device before exit

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Sep 30 12:07:51 UTC 2022


On 2022-09-26 at 08:17:20 +0200, Mauro Carvalho Chehab wrote:
> From: Chris Wilson <chris.p.wilson at intel.com>
> 
> Close the device fd before we check for leaks during the atexit
> handlers.
> 
> Signed-off-by: Chris Wilson <chris.p.wilson at intel.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>
> ---

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> 
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 00/76] at: https://lore.kernel.org/all/cover.1664173031.git.mchehab@kernel.org/
> 
>  tests/i915/gem_workarounds.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_workarounds.c b/tests/i915/gem_workarounds.c
> index fc5184925a88..5fb2d73fdd30 100644
> --- a/tests/i915/gem_workarounds.c
> +++ b/tests/i915/gem_workarounds.c
> @@ -31,6 +31,7 @@
>  #include "i915/gem_create.h"
>  #include "igt.h"
>  #include "igt_device.h"
> +#include "igt_types.h"
>  
>  #define PAGE_SIZE 4096
>  #define PAGE_ALIGN(x) ALIGN(x, PAGE_SIZE)
> @@ -238,7 +239,6 @@ static void check_workarounds(int fd, enum operation op, unsigned int flags)
>  igt_main
>  {
>  	struct intel_mmio_data mmio_data;
> -	int device = -1;
>  	const struct {
>  		const char *name;
>  		enum operation op;
> @@ -258,6 +258,7 @@ igt_main
>  		{ "-fd", FD },
>  		{ }
>  	}, *m;
> +	igt_fd_t(device);
>  
>  	igt_fixture {
>  		FILE *file;
> -- 
> 2.37.3
> 


More information about the igt-dev mailing list