[igt-dev] [PATCH i-g-t v2 0/3] ./scripts/igt_doc.py: speedup check logic
Mauro Carvalho Chehab
mauro.chehab at linux.intel.com
Wed Apr 12 12:50:30 UTC 2023
From: Mauro Carvalho Chehab <mchehab at kernel.org>
The logic which checks for missing/obsolete documentation is too
slow. Currently, on my notebook it takes 12 seconds:
$ time ./scripts/igt_doc.py --check --config tests/xe/xe_*json
real 0m12.085s
user 0m10.468s
sys 0m1.457s
Implent it on a different way, in order to speedup the build process.
After the change, it now takes less than 500ms:
$ time ./scripts/igt_doc.py --check --config tests/xe/xe_*json
real 0m0.460s
user 0m0.357s
sys 0m0.102s
It should be noticed that it is possible to speed it up even
further by running:
build/tests/* --list-subtests
tasks in parallel. I did some tests: the improvements weren't so
relevant on my notebook with 8 CPUs, and, on my tests with python 3.11
it seemed a little too fragile when using multithreading, as it was not
hard to mess with it, not having threads or subprocess forks not
happening, and without triggering an error.
As the benefit of such optimization was marginal, let's avoid the
additional complexity of multithreading.
---
v2:
- remove a now uneeded loop
Mauro Carvalho Chehab (3):
scripts/igt_doc.py: cleanup some pylint warnings
scripts/igt_doc.py: don't depend on igt_runner anymore
scripts/test_list.py: use a compiled regex for check
Mauro Carvalho Chehab (3):
scripts/igt_doc.py: cleanup some pylint warnings
scripts/igt_doc.py: don't depend on igt_runner anymore
scripts/test_list.py: use a compiled regex for check
docs/testplan/meson.build | 7 ++--
scripts/igt_doc.py | 11 +++---
scripts/test_list.py | 73 ++++++++++++++++++++++++++-------------
3 files changed, 55 insertions(+), 36 deletions(-)
--
2.39.2
More information about the igt-dev
mailing list