[igt-dev] [PATCH i-g-t 2/3] intel_gpu_top: Use full console width for global metrics

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Apr 14 15:26:40 UTC 2023


On 2023-03-28 at 13:54:28 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> It appears we had an off by one of a kind where we were not using the full
> width of the terminal window for the global metrics section.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tools/intel_gpu_top.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 39be916297e4..36da016c3df0 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -1960,8 +1960,7 @@ print_engines_header(struct engines *engines, double t,
>  				a = "          ENGINE     BUSY  ";
>  
>  			printf("\033[7m%s%*s%s\033[0m\n",
> -			       a, (int)(con_w - 1 - strlen(a) - strlen(b)),
> -			       " ", b);
> +			       a, (int)(con_w - strlen(a) - strlen(b)), " ", b);
>  
>  			lines++;
>  		}
> @@ -2000,7 +1999,6 @@ print_engine(struct engines *engines, unsigned int i, double t,
>  	print_groups(groups);
>  
>  	if (output_mode == INTERACTIVE) {
> -		unsigned int max_w = con_w - 1;
>  		unsigned int len;
>  		char buf[128];
>  		double val;
> @@ -2012,7 +2010,7 @@ print_engine(struct engines *engines, unsigned int i, double t,
>  			      engine->display_name, engine_items[0].buf);
>  
>  		val = pmu_calc(&engine->busy.val, 1e9, t, 100);
> -		print_percentage_bar(val, max_w > len ? max_w - len : 0, false);
> +		print_percentage_bar(val, con_w > len ? con_w - len : 0, false);
>  
>  		printf("%s\n", buf);
>  
> -- 
> 2.37.2
> 


More information about the igt-dev mailing list