[igt-dev] [PATCH i-g-t v4 8/8] lib: Fix igt_kms for drivers with 8 crtc's

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon Apr 17 12:39:11 UTC 2023


Hi,

On 2023-04-12 at 21:24:26 -0400, Zack Rusin wrote:
> From: Zack Rusin <zackr at vmware.com>
> 
> To avoid crashes in multiple tests on vmwgfx we need to extend the
> number of available pipe's to be at least as big as the the number
> returned by the virtualized drivers (which is 8).
> 
> Signed-off-by: Zack Rusin <zackr at vmware.com>
> Reviewed-by: Martin Krastev <krastevm at vmware.com>
> Reviewed-by: Maaz Mombasawala <mombasawalam at vmware.com>

imho this should have no impact on kms tests but I will ask also
Bhanuprakash, Ville and Karthik so +cc them on this.

Regards,
Kamil

> ---
>  lib/igt_kms.c | 2 +-
>  lib/igt_kms.h | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 50655f13..a23999cb 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -840,7 +840,7 @@ static igt_plane_t *igt_get_assigned_primary(igt_output_t *output, igt_pipe_t *p
>   */
>  const char *kmstest_pipe_name(enum pipe pipe)
>  {
> -	static const char str[] = "A\0B\0C\0D\0E\0F";
> +	static const char str[] = "A\0B\0C\0D\0E\0F\0G\0H";
>  
>  	_Static_assert(sizeof(str) == IGT_MAX_PIPES * 2,
>  		       "Missing pipe name");
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 2b917925..d3a39e24 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -62,6 +62,8 @@ enum pipe {
>          PIPE_D,
>          PIPE_E,
>          PIPE_F,
> +	PIPE_G,
> +	PIPE_H,
>          IGT_MAX_PIPES
>  };
>  const char *kmstest_pipe_name(enum pipe pipe);
> -- 
> 2.39.2
> 


More information about the igt-dev mailing list