[igt-dev] [PATCH] i915/i915_hangman: use igt_describe_f()

[Kamil Konieczny]

On 2023-04-21 at 08:51:53 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab at kernel.org>
> 
> Instead of re-implementing the wheel with a temporary buffer,
> to use dynamic arguments to igt_describe(), just call igt_describe_f()
> variant.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

> ---
>  tests/i915/i915_hangman.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c
> index 8acce8f1a493..dd396c4e9709 100644
> --- a/tests/i915/i915_hangman.c
> +++ b/tests/i915/i915_hangman.c
> @@ -463,8 +463,7 @@ static void do_tests(const char *name, const char *prefix,
>  	const struct intel_execution_engine2 *e;
>  	char buff[256];
>  
> -	snprintf(buff, sizeof(buff), "Per engine error capture (%s reset)", name);
> -	igt_describe(buff);
> +	igt_describe_f("Per engine error capture (%s reset)", name);
>  	snprintf(buff, sizeof(buff), "%s-error-state-capture", prefix);
>  	igt_subtest_with_dynamic(buff) {
>  		for_each_ctx_engine(device, ctx, e) {
> @@ -473,8 +472,7 @@ static void do_tests(const char *name, const char *prefix,
>  		}
>  	}
>  
> -	snprintf(buff, sizeof(buff), "Per engine hang recovery (spin, %s reset)", name);
> -	igt_describe(buff);
> +	igt_describe_f("Per engine hang recovery (spin, %s reset)", name);
>  	snprintf(buff, sizeof(buff), "%s-engine-hang", prefix);
>  	igt_subtest_with_dynamic(buff) {
>                  int has_gpu_reset = 0;
> @@ -494,8 +492,7 @@ static void do_tests(const char *name, const char *prefix,
>  		}
>  	}
>  
> -	snprintf(buff, sizeof(buff), "Per engine hang recovery (invalid CS, %s reset)", name);
> -	igt_describe(buff);
> +	igt_describe_f("Per engine hang recovery (invalid CS, %s reset)", name);
>  	snprintf(buff, sizeof(buff), "%s-engine-error", prefix);
>  	igt_subtest_with_dynamic(buff) {
>  		int has_gpu_reset = 0;
> -- 
> 2.39.2
>