[igt-dev] [PATCH i-g-t 2/3] tests/kms_plane_scaling: fix variable misspelling

Kamil Konieczny kamil.konieczny at linux.intel.com
Tue Apr 25 07:55:05 UTC 2023


Hi,

On 2023-04-24 at 15:33:59 -0300, Maíra Canal wrote:
> As the function test_scaler_with_multi_pipe_plane() intends to test two
> planes, it is necessary to check the output of both planes, not only
> one. Therefore, instead of checking the variable ret1 twice, check the
> variable ret2.
> 
> Fixes: 56bedcde ("tests/kms_plane_scaling: Cleanup")
> Signed-off-by: Maíra Canal <mcanal at igalia.com>
> ---
>  tests/kms_plane_scaling.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 302fffcd..7f5cb00d 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -926,7 +926,7 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
>  	cleanup_fbs(d);
>  
>  	igt_skip_on_f(ret1 == -ERANGE || ret1 == -EINVAL ||
> -		      ret2 == -ERANGE || ret1 == -EINVAL,
> +		      ret2 == -ERANGE || ret2 == -EINVAL,

Good catch, thank you for the fix,

Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>

>  		      "Scaling op is not supported by driver\n");
>  	igt_assert_eq(ret1 && ret2, 0);
>  }
> -- 
> 2.40.0
> 


More information about the igt-dev mailing list