[igt-dev] [PATCH i-g-t v6 08/15] lib/intel_batchbuffer: Add Xe support in intel-bb

[Zbigniew Kempczyński]

On Wed, Apr 26, 2023 at 11:59:43AM +0200, Manszewski, Christoph wrote:
> > +			/* Use safe start offset instead assuming 0x0 is safe */
> > +			start = max_t(uint64_t, start, gem_detect_safe_start_offset(fd));
> 
> I'm not sure this is relevant since it should be related to the allocator
> scenario, however originally we executed this line regardless of the
> 'do_relocs' value.

If you mean allocator also adopts start/end for intel-bb we want
to override this, just to not rely on default allocator start/end
offset detection.

> 
> Upholding:
> Reviewed-by: Christoph Manszewski <christoph.manszewski at intel.com>

Thank you for the review.

--
Zbigniew

> 
> Christoph
> 
> 
> > +
> > +			/* if relocs are set we won't use an allocator */
> > +			ibb->allocator_handle =
> > +				intel_allocator_open_full(fd, ctx,
> > +							  start, end,
> > +							  allocator_type,
> > +							  strategy, 0);