[igt-dev] [PATCH i-g-t v6 06/15] lib/intel_bufops: Add Xe support in bufops

[Zbigniew Kempczyński]

On Wed, Apr 26, 2023 at 02:18:01PM +0200, Manszewski, Christoph wrote:
> > +/**
> > + * buf_ops_get_driver
> > + * @bops: pointer to buf_ops
> > + *
> > + * Returns: intel driver enum value
> > + */
> > +enum intel_driver buf_ops_get_driver(struct buf_ops *bops)
> > +{
> 
> Maybe 'igt_assert(bops)' here? At least that's what buf_ops_get_fd does, and
> it adds some layer of protection over just wrapping 'bops->driver'.

Agree, this is public function and checking bops != null makes sense.

--
Zbigniew

> 
> Anyway:
> Reviewed-by: Christoph Manszewski <christoph.manszewski at intel.com>
>