[igt-dev] [PATCH i-g-t] tests/xe/xe_query.c: Update subtest query-engines

[Kumar, Janga Rahul]

> -----Original Message-----
> From: Ch, Sai Gowtham <sai.gowtham.ch at intel.com>
> Sent: 27 April 2023 17:50
> To: Kumar, Janga Rahul <janga.rahul.kumar at intel.com>; igt-
> dev at lists.freedesktop.org; Gandi, Ramadevi <ramadevi.gandi at intel.com>
> Subject: RE: [PATCH i-g-t] tests/xe/xe_query.c: Update subtest query-engines
> 
> 
> 
> > -----Original Message-----
> > From: Kumar, Janga Rahul <janga.rahul.kumar at intel.com>
> > Sent: Thursday, April 27, 2023 5:28 PM
> > To: igt-dev at lists.freedesktop.org; Gandi, Ramadevi
> > <ramadevi.gandi at intel.com>
> > Cc: Ch, Sai Gowtham <sai.gowtham.ch at intel.com>
> > Subject: RE: [PATCH i-g-t] tests/xe/xe_query.c: Update subtest
> > query-engines
> >
> >
> >
> > > -----Original Message-----
> > > From: Kumar, Janga Rahul <janga.rahul.kumar at intel.com>
> > > Sent: 25 April 2023 18:06
> > > To: igt-dev at lists.freedesktop.org; Gandi, Ramadevi
> > > <ramadevi.gandi at intel.com>; Kumar, Janga Rahul
> > > <janga.rahul.kumar at intel.com>
> > > Subject: [PATCH i-g-t] tests/xe/xe_query.c: Update subtest
> > > query-engines
> > >
> > > From: Janga Rahul Kumar <janga.rahul.kumar at intel.com>
> > >
> > > Log engine instance and tile info along with engine type.
> > >
> > > Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar at intel.com>
> > > ---
> > >  tests/xe/xe_query.c | 5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/tests/xe/xe_query.c b/tests/xe/xe_query.c index
> > > 3f038225..161386d8 100644
> > > --- a/tests/xe/xe_query.c
> > > +++ b/tests/xe/xe_query.c
> > > @@ -183,8 +183,9 @@ test_query_engines(int fd)
> > >
> > >  	xe_for_each_hw_engine(fd, hwe) {
> > >  		igt_assert(hwe);
> > > -		igt_info("engine %d: %s\n", i++,
> > > -			xe_engine_class_string(hwe->engine_class));
> > > +		igt_info("engine %d: %s, engine instance: %d , tile: TILE-%d\n",
> 
> Do we really need tile info here ?
Yes, It helps in identifying the number of engines per tile.
> Fix this engine instance: %d , --> engine instance: %d,
> > > i++,
> > > +			 xe_engine_class_string(hwe->engine_class), hwe-
> > > >engine_instance,
> > > +								    hwe-
> > > >gt_id);
> > >  	}
> With the above fixed,
> Reviewed-by: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
> > >
> > >  	igt_assert(i > 0);
> > > --
> > > 2.25.1