[igt-dev] [PATCH i-g-t 0/4] Update code to use xe_sysfs_gt_open

Upadhyay, Tejas tejas.upadhyay at intel.com
Tue Aug 1 05:01:50 UTC 2023



> -----Original Message-----
> From: Dandamudi, Priyanka <priyanka.dandamudi at intel.com>
> Sent: Monday, July 31, 2023 7:40 PM
> To: Kumar, Janga Rahul <janga.rahul.kumar at intel.com>; igt-
> dev at lists.freedesktop.org; Upadhyay, Tejas <tejas.upadhyay at intel.com>;
> Dandamudi, Priyanka <priyanka.dandamudi at intel.com>
> Subject: [PATCH i-g-t 0/4] Update code to use xe_sysfs_gt_open
> 
> From: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> 
> Tests have been updated to use xe_sysfs_gt_open function.
> Updated code to work non privileged user.
> Modified documentation.
> 
> v2: Split updated tests patch into 2 patches
> 1 with only to use xe_sysfs_gt_open and other to update documentation,
> non privileged user.(Tejas)

Please change tests with following consideration as KMD behaves like that now,

1. These parameter can be set through sysfs, (and sysfs setting would always be done by super user) , normal permission cant change sysfs
2. Other way to set these parameters is through ioctls (like engine_create and passing parameter), here we will have differentiation for superuser and normal user as we used to do in tests till now.

So if you are writing tests for sysfs then please follow 1.

Thanks,
Tejas
> 
> Cc: Tejas Upadhyay <tejas.upadhyay at intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> 
> Priyanka Dandamudi (4):
>   xe/xe_sysfs: Updated tests to use xe_sysfs_gt_open
>   xe/xe_sysfs: Modified code to work for non priv user
>   xe-fast-feedback.testlist: Add sysfs tests to BAT
>   tests/intel-ci: Remove xe_sysfs from blacklist
> 
>  tests/intel-ci/xe-fast-feedback.testlist | 10 ++++++++
>  tests/intel-ci/xe.blocklist.txt          |  2 --
>  tests/xe/xe_sysfs_defaults.c             | 16 +++++++------
>  tests/xe/xe_sysfs_scheduler.c            | 29 +++++++++++++++++-------
>  4 files changed, 40 insertions(+), 17 deletions(-)
> 
> --
> 2.25.1



More information about the igt-dev mailing list