[igt-dev] [PATCH i-g-t 2/5] xe/xe_sysfs_scheduler: Try to set sysfs scheduler with default min

[Upadhyay, Tejas]

> -----Original Message-----
> From: Upadhyay, Tejas
> Sent: Thursday, August 3, 2023 1:10 PM
> To: Dandamudi, Priyanka <Priyanka.Dandamudi at intel.com>; Kumar, Janga
> Rahul <janga.rahul.kumar at intel.com>; igt-dev at lists.freedesktop.org
> Subject: RE: [PATCH i-g-t 2/5] xe/xe_sysfs_scheduler: Try to set sysfs
> scheduler with default min
> 
> 
> 
> > -----Original Message-----
> > From: Dandamudi, Priyanka <priyanka.dandamudi at intel.com>
> > Sent: Thursday, August 3, 2023 11:38 AM
> > To: Kumar, Janga Rahul <janga.rahul.kumar at intel.com>; igt-
> > dev at lists.freedesktop.org; Upadhyay, Tejas <tejas.upadhyay at intel.com>;
> > Dandamudi, Priyanka <priyanka.dandamudi at intel.com>
> > Subject: [PATCH i-g-t 2/5] xe/xe_sysfs_scheduler: Try to set sysfs
> > scheduler with default min
> >
> > From: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> >
> > Test tries to set sysfs scheduler with default min which is beyond
> > local min and assert is expected to be not equal to the set one.
> >
> > Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> > ---
> >  tests/xe/xe_sysfs_scheduler.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/xe/xe_sysfs_scheduler.c
> > b/tests/xe/xe_sysfs_scheduler.c index 2a113ea0f..f199d6be8 100644
> > --- a/tests/xe/xe_sysfs_scheduler.c
> > +++ b/tests/xe/xe_sysfs_scheduler.c
> > @@ -94,7 +94,7 @@ static void test_min_max(int xe, int engine, const
> > char
> > **property)
> >
> >  	igt_sysfs_printf(engine, property[0], "%d", default_min);
> >  	igt_sysfs_scanf(engine, property[0], "%u", &set);
> > -	igt_assert_eq(set, default_min);
> > +	igt_assert_neq(set, default_min);
> 
> Should we make sure we store-restore property[0] as well at start and end of
> test respectively.

With store-restore for property[0] added, 
Reviewed-by: Tejas Upadhyay <tejas.upadhyay at intel.com>

> 
> Thanks,
> Tejas
> >
> >  	igt_sysfs_printf(engine, property[0], "%d", min);
> >  	igt_sysfs_scanf(engine, property[0], "%u", &set);
> > --
> > 2.25.1