[igt-dev] [PATCH i-g-t v2 1/2] lib/igt_pm: Remove pci_system_{init, cleanup}

Anshuman Gupta anshuman.gupta at intel.com
Fri Aug 11 11:10:25 UTC 2023


From: Anshuamn Gupta <anshuman.gupta at intel.com>

As xe_pm igt test fixture is calling igt_device_get_pci_device()
that makes igt core library to initialize libpciaccess
pci_system_init() and register a exit handler for its cleanup.
Therefore remove these unnecessary calls from igt_pm lib.

v2:
- Commit log improvements. [Rodrigo]

Signed-off-by: Anshuamn Gupta <anshuman.gupta at intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
---
 lib/igt_pm.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 704acf7d1..d1d7be9a1 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -1140,9 +1140,6 @@ igt_pm_setup_pci_card_power_attrs(struct pci_device *pci_dev, bool save_attrs, i
 	ret = pci_device_get_bridge_buses(pci_dev, &primary, &secondary, &subordinate);
 	igt_assert(!ret);
 
-	ret = pci_system_init();
-	igt_assert(!ret);
-
 	match.domain = pci_dev->domain;
 	match.bus = PCI_MATCH_ANY;
 	match.dev = PCI_MATCH_ANY;
@@ -1185,7 +1182,6 @@ void igt_pm_enable_pci_card_runtime_pm(struct pci_device *root,
 		delay = igt_pm_get_autosuspend_delay(i915);
 
 	igt_pm_setup_pci_card_power_attrs(root, false, delay);
-	pci_system_cleanup();
 }
 
 /**
@@ -1289,7 +1285,6 @@ void igt_pm_restore_pci_card_runtime_pm(void)
 	}
 
 	memset(__pci_dev_pwrattr, 0, sizeof(__pci_dev_pwrattr));
-	pci_system_cleanup();
 }
 
 static void igt_pm_print_pci_dev_runtime_status(struct pci_device *pci_dev)
-- 
2.25.1



More information about the igt-dev mailing list