[igt-dev] [PATCH i-g-t v4 4/5] tests/xe: Add a test that validates residency during s2idle

[Riana Tauro]

During s2idle, the device is powered up and GT C6 enabled
so we expect the residency to increase across suspend.
Add a test that validates the residency over a s2idle cycle
and checks if it is greater than the autoresume delay
or within tolerance.

v2: skip d3cold disable for igfx (Anshuman)
v3: rename test flag to TEST_IDLE
    reorder variables (Anshuman)
v4: check if residency is greater than autoresume delay as
    expected. Assert only if residency is lesser than autoresume
    delay and not within tolerance.

Signed-off-by: Riana Tauro <riana.tauro at intel.com>
---
 tests/xe/xe_pm_residency.c | 58 ++++++++++++++++++++++++++++++++++----
 1 file changed, 53 insertions(+), 5 deletions(-)

diff --git a/tests/xe/xe_pm_residency.c b/tests/xe/xe_pm_residency.c
index 4936de166..fd4876eaf 100644
--- a/tests/xe/xe_pm_residency.c
+++ b/tests/xe/xe_pm_residency.c
@@ -10,8 +10,10 @@
  * Functionality: GT C States
  * Test category: functionality test
  */
+#include <limits.h>
 
 #include "igt.h"
+#include "igt_device.h"
 #include "igt_sysfs.h"
 
 #include "xe/xe_query.h"
@@ -29,6 +31,11 @@ const double tolerance = 0.1;
 		     (tol) * 100.0, (tol) * 100.0, \
 		     (double)(ref))
 
+enum test_type {
+	TEST_S2IDLE,
+	TEST_IDLE,
+};
+
 /**
  * SUBTEST: gt-c6-on-idle
  * Description: Validate GT C6 state on idle
@@ -38,6 +45,11 @@ const double tolerance = 0.1;
  * Description: basic residency test to validate idle residency
  *		measured over a time interval is within the tolerance
  * Run type: FULL
+ *
+ * SUBTEST: gt-c6-freeze
+ * Description: Validate idle residency measured over suspend(s2idle)
+ *              is greater than suspend time or within tolerance
+ * Run type: FULL
  */
 IGT_TEST_DESCRIPTION("Tests for gtidle properties");
 
@@ -69,15 +81,35 @@ static unsigned long read_idle_residency(int fd, int gt)
 	return residency;
 }
 
-static void test_idle_residency(int fd, int gt)
+static void test_idle_residency(int fd, int gt, enum test_type flag)
 {
 	unsigned long elapsed_ms, residency_start, residency_end;
 
 	igt_assert_f(igt_wait(xe_is_gt_in_c6(fd, gt), 1000, 1), "GT not in C6\n");
 
-	residency_start = read_idle_residency(fd, gt);
-	elapsed_ms = measured_usleep(SLEEP_DURATION * 1000) / 1000;
-	residency_end = read_idle_residency(fd, gt);
+	if (flag == TEST_S2IDLE) {
+		/*
+		 * elapsed time during suspend is approximately equal to autoresume delay
+		 * when a full suspend cycle(SUSPEND_TEST_NONE) is used.
+		 */
+		elapsed_ms = igt_get_autoresume_delay(SUSPEND_STATE_FREEZE);
+		residency_start = read_idle_residency(fd, gt);
+		igt_system_suspend_autoresume(SUSPEND_STATE_FREEZE, SUSPEND_TEST_NONE);
+		residency_end = read_idle_residency(fd, gt);
+
+		/*
+		 * Idle residency may increase even after suspend, only assert if residency
+		 * is lesser than autoresume delay and is not within tolerance.
+		 */
+		if ((residency_end - residency_start) >= elapsed_ms)
+			return;
+	}
+
+	if (flag == TEST_IDLE) {
+		residency_start = read_idle_residency(fd, gt);
+		elapsed_ms = measured_usleep(SLEEP_DURATION * 1000) / 1000;
+		residency_end = read_idle_residency(fd, gt);
+	}
 
 	igt_info("Measured %lums of idle residency in %lums\n",
 		 residency_end - residency_start, elapsed_ms);
@@ -87,7 +119,9 @@ static void test_idle_residency(int fd, int gt)
 
 igt_main
 {
+	uint32_t d3cold_allowed;
 	int fd, gt;
+	char pci_slot_name[NAME_MAX];
 
 	igt_fixture {
 		fd = drm_open_driver(DRIVER_XE);
@@ -99,10 +133,24 @@ igt_main
 		xe_for_each_gt(fd, gt)
 			igt_assert_f(igt_wait(xe_is_gt_in_c6(fd, gt), 1000, 1), "GT not in C6\n");
 
+	igt_describe("Validate idle residency measured over suspend cycle is within the tolerance");
+	igt_subtest("gt-c6-freeze") {
+		if (xe_has_vram(fd)) {
+			igt_device_get_pci_slot_name(fd, pci_slot_name);
+			igt_pm_get_d3cold_allowed(pci_slot_name, &d3cold_allowed);
+			igt_pm_set_d3cold_allowed(pci_slot_name, 0);
+		}
+		xe_for_each_gt(fd, gt)
+			test_idle_residency(fd, gt, TEST_S2IDLE);
+
+		if (xe_has_vram(fd))
+			igt_pm_set_d3cold_allowed(pci_slot_name, d3cold_allowed);
+	}
+
 	igt_describe("Validate idle residency measured over a time interval is within the tolerance");
 	igt_subtest("idle-residency")
 		xe_for_each_gt(fd, gt)
-			test_idle_residency(fd, gt);
+			test_idle_residency(fd, gt, TEST_IDLE);
 
 	igt_fixture {
 		close(fd);
-- 
2.40.0