[igt-dev] [PATCH i-g-t] tests/i915/kms_dsc_helper: %s/platform/source

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Aug 11 16:18:38 UTC 2023


Hi Swati,

small nit regarding subject, imho better:
rename by_platform to by_source

Also it looks better without '%'.

On 2023-08-10 at 15:41:42 +0530, Swati Sharma wrote:
> Rename function from platform to source.
-------- ^
Technically speaking you rename a word in function, not all name
so it may be written here. Also maybe write few words why?

Regards,
Kamil

> 
> Signed-off-by: Swati Sharma <swati2.sharma at intel.com>
> ---
>  tests/i915/kms_dsc_helper.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/kms_dsc_helper.c b/tests/i915/kms_dsc_helper.c
> index df999c9bd..44edd5ca9 100644
> --- a/tests/i915/kms_dsc_helper.c
> +++ b/tests/i915/kms_dsc_helper.c
> @@ -120,7 +120,7 @@ void force_dsc_output_format(int drmfd, igt_output_t *output,
>  }
>  
>  /* YCbCr420 DSC is supported on display version 14+ with DSC1.2a */
> -static bool is_dsc_output_format_supported_by_platform(int disp_ver, enum dsc_output_format output_format)
> +static bool is_dsc_output_format_supported_by_source(int disp_ver, enum dsc_output_format output_format)
>  {
>  	if (disp_ver < 14 && output_format == DSC_FORMAT_YCBCR420) {
>  		igt_debug("Output format DSC YCBCR420 not supported on D13 and older platforms\n");
> @@ -133,7 +133,7 @@ static bool is_dsc_output_format_supported_by_platform(int disp_ver, enum dsc_ou
>  bool is_dsc_output_format_supported(int drmfd, int disp_ver, igt_output_t *output,
>  				    enum dsc_output_format output_format)
>  {
> -	if (!is_dsc_output_format_supported_by_platform(disp_ver, output_format))
> +	if (!is_dsc_output_format_supported_by_source(disp_ver, output_format))
>  		return false;
>  
>  	if (!igt_is_dsc_output_format_supported_by_sink(drmfd, output->name, output_format)) {
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list