[igt-dev] [i-g-t V6 72/81] tests/kms_setmode: Document each subtest for testplan

[B, Jeevan]

Hi, 

> -----Original Message-----
> From: B S, Karthik <karthik.b.s at intel.com>
> Sent: Monday, August 14, 2023 10:36 AM
> To: Modem, Bhanuprakash <bhanuprakash.modem at intel.com>; igt-
> dev at lists.freedesktop.org; B, Jeevan <jeevan.b at intel.com>
> Subject: Re: [i-g-t V6 72/81] tests/kms_setmode: Document each subtest for
> testplan
> 
> Hi,
> 
> On 8/12/2023 12:16 AM, Bhanuprakash Modem wrote:
> > Add documentation for all kms tests which is used by IGT testplan
> > documentation.
> >
> > V2: - Fix test description
> >
> > Cc: Karthik B S <karthik.b.s at intel.com>
> > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> > ---
> >   tests/kms_setmode.c | 60
> +++++++++++++++++++++++++++++++++++++++++++++
> >   1 file changed, 60 insertions(+)
> >
> > diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c index
> > 035bbd0b0..19bda6b26 100644
> > --- a/tests/kms_setmode.c
> > +++ b/tests/kms_setmode.c
> > @@ -31,6 +31,66 @@
> >   #include <sys/time.h>
> >   #include <math.h>
> >   #include "xe/xe_query.h"
> > +/**
> > + * TEST: kms setmode
> > + * Category: Display
> > + * Description: Tests the mode by iterating through all valid/invalid
> crtc/connector
> > + *              combinations
> > + *
> > + * SUBTEST: basic
> > + * Description: Tests the vblank timing by iterating through all valid
> crtc/connector
> > + *              combinations
> > + * Driver requirement: any
> > + * Functionality: kms_core, vblank
> > + * Mega feature: General Display Features
> > + * Run type: FULL
> > + * Test category: functionality test
> > + *
> > + * SUBTEST: basic-clone-single-crtc
> > + * Description: Tests the mode by cloning the single crtc by iterating
> through all
> > + *              valid crtc/connector combinations
> 
> The descriptions seem confusing to me at least.
> 
> @Jeevan: Please provide your inputs on these as you're looking into these
> subtests.

AFIK both 'basic-clone-single-crtc' and 'invalid-clone-single-crtc' tests aim to assess a scenario where two connectors are attempted to be run with a single CRTC. 
Similarly, the 'invalid-clone-exclusive-crtc' and 'clone-exclusive-crtc' test attempts to run two connectors with two CRTCs  

> 
> Thanks,
> Karthik.B.S
> > + * Driver requirement: any
> > + * Functionality: kms_core
> > + * Mega feature: General Display Features
> > + * Run type: FULL
> > + * Test category: functionality test
> > + *
> > + * SUBTEST: clone-exclusive-crtc
> > + * Description: Tests the mode by cloning the single exclusive crtc by
> iterating
> > + *              through all valid crtc/connector combinations
> > + * Driver requirement: any
> > + * Functionality: kms_core
> > + * Mega feature: General Display Features
> > + * Run type: FULL
> > + * Test category: functionality test
> > + *
> > + * SUBTEST: invalid-clone-exclusive-crtc
> > + * Description: Tests the mode by cloning the single exclusive crtc by
> iterating
> > + *              through all invalid crtc/connector combinations
> > + * Driver requirement: any
> > + * Functionality: kms_core
> > + * Mega feature: General Display Features
> > + * Run type: FULL
> > + * Test category: functionality test
> > + *
> > + * SUBTEST: invalid-clone-single-crtc
> > + * Description: Tests the mode by cloning the single crtc by iterating
> through all
> > + *              invalid crtc/connector combinations
> > + * Driver requirement: any
> > + * Functionality: kms_core
> > + * Mega feature: General Display Features
> > + * Run type: FULL
> > + * Test category: functionality test
> > + *
> > + * SUBTEST: invalid-clone-single-crtc-stealing
> > + * Description: Tests the stealing mode by cloning the single crtc by
> iterating
> > + *              through all invalid crtc/connector combinations
> > + * Driver requirement: any
> > + * Functionality: kms_core
> > + * Mega feature: General Display Features
> > + * Run type: FULL
> > + * Test category: functionality test
> > + */
> >
> >   #define MAX_CONNECTORS  10
> >   #define MAX_CRTCS       6